Features/442 to 446 #449
Closed
Features/442 to 446 #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Dec 12, 2022
ddelpiano
requested changes
Dec 16, 2022
| @@ -143,14 +140,18 @@ class CameraControls extends Component { | |||
| icon: null, | |||
| }); | |||
| } | |||
|
|
|||
| const buttonStyles = { color: '#fc6320', } | |||
There was a problem hiding this comment.
this does not work right now, it is hardcoded for geppetto but applications are customising the color of these controls
There was a problem hiding this comment.
Correct, this should be customizable through props. Thanks for the review 👍
|
@enicolasgomez this is a breaking change (tested in netpyne), imho it should go in a major release. |
|
If the issues solved are in different milestones it will be beneficial to split the PR into multiple PR's (ideally one per issue, but at least one per milestone) |
This was
unlinked from
issues
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #442 #443 #444 #446