Feature/high resolution screenshot #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no functional changes though
seankmartin
commented
Aug 30, 2024
This reverts commit 302c119.
NA-362 screenshot styling updates
feat(python): support resolution scale factor in CLI
Feature/na 356 Screenshot dialog UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature goal:
Support taking cropped screenshots from neuroglancer of only the data panels. Support taking these at x1, x2, or x4 scale.
In x2 and x4 scale, the canvas is resized. This means that 2D panels kind of "zoom out" to support the extra pixels. 3D panels on the other hand keep their view fixed, but have more pixels in the framebuffer.
Overall idea of files/classes:
ScreenshotHandleris what actually interacts with the data to try and grab screenshot data, and repeatedly grab statistics while this is loading.ScreenshotManagerinteracts with the display context to start theScreenshotHandlerprocess. It also receives information from theScreenshotHandlerand passes this on to the screenshot UI menu when appropriate. It saves the file when complete, and stops screenshots automatically if they hang.ScreenshotDialoghandles the user input to trigger actions in theScreenshotManager, and shows updates from theScreenshotManagerto the user.