Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCKAN-248 feat: Update from_entities when applicable #223

Merged
merged 1 commit into from
Feb 10, 2024
Merged

SCKAN-248 feat: Update from_entities when applicable #223

merged 1 commit into from
Feb 10, 2024

Conversation

afonsobspinto
Copy link
Member

@afonsobspinto afonsobspinto commented Feb 9, 2024 •
edited
Loading

closes https://metacell.atlassian.net/browse/SCKAN-248
(https://metacell.atlassian.net/browse/SCKAN-248?focusedCommentId=13730)

  • Empties the from_entities set on the vias/destinations created from neuronDM when applicable (from entities set equal to previous layer anatomical entities)

image

image

@zsinnema zsinnema merged commit 14c0732 into develop Feb 10, 2024
1 check failed
zsinnema
zsinnema reviewed Feb 11, 2024
View reviewed changes
Copy link
Contributor

@zsinnema zsinnema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsinnema zsinnema zsinnema approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afonsobspinto @zsinnema