Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editing business logic to remove condition not anymore required #266

Closed
wants to merge 3 commits into from
Closed

editing business logic to remove condition not anymore required #266

wants to merge 3 commits into from

Conversation

ddelpiano
Copy link
Member

No description provided.

@ddelpiano ddelpiano requested a review from zsinnema April 17, 2024 14:58
zsinnema
zsinnema requested changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@zsinnema zsinnema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical: @ddelpiano the removal of the sex being mandatory leads to a breaking issue in the export. The get rows will raise this exception:

sckan-composer/backend/composer/services/export_services.py

Line 400 in a002cd6

raise UnexportableConnectivityStatement("Error getting sex row")
which will mark the ConnectivityStatement as invalid
please fix the issue

@ddelpiano ddelpiano requested a review from zsinnema April 22, 2024 11:37
@ddelpiano ddelpiano closed this Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsinnema zsinnema Awaiting requested review from zsinnema

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ddelpiano @zsinnema