Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCKAN-323 fix: Update frontend to send new owner_id on retry #357

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

afonsobspinto
Copy link
Member

@afonsobspinto afonsobspinto commented Nov 14, 2024

closes https://metacell.atlassian.net/browse/SCKAN-323

Error explained:

  • The frontend was making an update request that included a change of owner.
  • The backend applied the change and then ran into a permission error on a post processing step

Solution:

  • This PR changes the frontend request to include the correct/desired owner for the statement
  • It also refactors the backend to move the update logic from the view to the serializer.
  • Makes the owner and owner_id read_only on the update and provides a more descriptive error message when those are included in the incoming request
2024-11-14.12-51-45.mp4

Copy link
Member

@ddelpiano ddelpiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ddelpiano ddelpiano merged commit 03f08d2 into develop Nov 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants