fix(keyring-api)!: use CaipAccountId for ResolveAccountAddress.address #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccharly
force-pushed
the
fix/resolve-account-address-caip-10
branch
from
c490b26 to
f381539
Compare
ccharly
force-pushed
the
fix/resolve-account-address-caip-10
branch
from
f381539 to
4c36f76
Compare
danroc
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We forgot to mention this in SIP-26, but the
addressbeing returned byresolveAccountAddressmust use CAIP-10 format.This is already being checked by the consumers of this method, but it's better that we catch any errors related to this at API level.