Skip to content

Commit

Permalink
chore: Remove broken MV3 perf stats (#29408)
Browse files Browse the repository at this point in the history
## **Description**

Remove broken MV3 reports. These reports relied upon data from the
`mv3-perf-stats` E2E test job, which itself relied upon the
`user-data-dir` chromedriver setting removed in #24696. They have been
broken since that PR.

These reports were very useful in prioritizing MV3 work at the time, but
we haven't needed them recently.

The `mv3-stats` E2E test suite has also been removed (this is an older
version of `mv3-perf-stats` that has been unused for even longer), along
with the charts that were used for this report.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29408?quickstart=1)

## **Related issues**

Relates to #28572

## **Manual testing steps**

Check that the `metamaskbot` comment no longer has the links to these
broken reports. They look like this:

- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats

## **Screenshots/Recordings**

N/A

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
Gudahtt authored Dec 20, 2024
1 parent f64a2d0 commit 57d564d
Show file tree
Hide file tree
Showing 15 changed files with 0 additions and 9,563 deletions.
42 changes: 0 additions & 42 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -278,9 +278,6 @@ workflows:
- user-actions-benchmark:
requires:
- prep-build-test
- stats-module-load-init:
requires:
- prep-build-test
- job-publish-prerelease:
requires:
- prep-deps
Expand All @@ -294,7 +291,6 @@ workflows:
- prep-build-ts-migration-dashboard
- benchmark
- user-actions-benchmark
- stats-module-load-init
- all-tests-pass
- job-publish-release:
filters:
Expand Down Expand Up @@ -1271,44 +1267,6 @@ jobs:
paths:
- test-artifacts

stats-module-load-init:
executor: node-browsers-small
steps:
- run: *shallow-git-clone-and-enable-vnc
- run: sudo corepack enable
- attach_workspace:
at: .
- run:
name: Move test build to dist
command: mv ./dist-test ./dist
- run:
name: Move test zips to builds
command: mv ./builds-test ./builds
- run:
name: Run page load benchmark
command: |
mkdir -p test-artifacts/chrome/
cp -R development/charts/flamegraph test-artifacts/chrome/initialisation
cp -R development/charts/flamegraph/chart test-artifacts/chrome/initialisation/background
cp -R development/charts/flamegraph/chart test-artifacts/chrome/initialisation/ui
cp -R development/charts/table test-artifacts/chrome/load_time
- run:
name: Run page load benchmark
command: yarn mv3:stats:chrome --out test-artifacts/chrome
- run:
name: Install jq
command: sudo apt install jq -y
- run:
name: Record bundle size at commit
command: ./.circleci/scripts/bundle-stats-commit.sh
- store_artifacts:
path: test-artifacts
destination: test-artifacts
- persist_to_workspace:
root: .
paths:
- test-artifacts

job-publish-prerelease:
executor: node-browsers-medium
steps:
Expand Down
1 change: 0 additions & 1 deletion .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ node_modules/**/*
/app/vendor/**
/builds/**/*
/coverage/**/*
/development/charts/**
/development/chromereload.js
/development/ts-migration-dashboard/filesToConvert.json
/development/ts-migration-dashboard/build/**
Expand Down
1 change: 0 additions & 1 deletion .vscode/cspell.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@
"devcontainers",
"endregion",
"ensdomains",
"flamegraph",
"FONTCONFIG",
"hardfork",
"hexstring",
Expand Down
167 changes: 0 additions & 167 deletions development/charts/flamegraph/chart/index.html

This file was deleted.

Loading

0 comments on commit 57d564d

Please sign in to comment.