-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update eth-trezor-keyring to @metamask/eth-trezor-keyring v1.0.0 #18062
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
yarn.lock
Outdated
languageName: node | ||
linkType: hard | ||
|
||
"@chainsafe/ssz@npm:0.9.4": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re ethereumjs/ethereumjs-monorepo#2622 - should a newer version with bumped deps be used here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably, yes
@brad-decker what was the plan for that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are ignoring it in the bundler, (it wont' be included in bundles) -- also you can't merge this, the bump to ethereumjs/tx requires updates throughout the codebase that are expressed in #18302
e3cc9de
to
b633ba9
Compare
b633ba9
to
e1f88a2
Compare
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview:
🚮 Removed packages: [email protected] |
Builds ready [1ef69b2]
Page Load Metrics (1371 ± 22 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
blocked by #18302 |
closing in favour of #18302 |
Updates the version to https://github.com/MetaMask/eth-trezor-keyring/releases/tag/v1.0.0