Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eth-trezor-keyring to @metamask/eth-trezor-keyring v1.0.0 #18062

Closed
wants to merge 7 commits into from

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Mar 8, 2023

@danjm danjm requested a review from a team as a code owner March 8, 2023 19:01
@danjm danjm requested a review from jpuri March 8, 2023 19:01
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

yarn.lock Outdated
languageName: node
linkType: hard

"@chainsafe/ssz@npm:0.9.4":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re ethereumjs/ethereumjs-monorepo#2622 - should a newer version with bumped deps be used here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably, yes

@brad-decker what was the plan for that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are ignoring it in the bundler, (it wont' be included in bundles) -- also you can't merge this, the bump to ethereumjs/tx requires updates throughout the codebase that are expressed in #18302

@danjm danjm force-pushed the bump-trezor-keyring-version branch from e3cc9de to b633ba9 Compare April 12, 2023 18:30
@danjm danjm force-pushed the bump-trezor-keyring-version branch from b633ba9 to e1f88a2 Compare April 12, 2023 19:09
@socket-security
Copy link

socket-security bot commented Apr 12, 2023

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
@metamask/[email protected] None +18 metamaskbot

🚮 Removed packages: [email protected]

@metamaskbot
Copy link
Collaborator

Builds ready [1ef69b2]
Page Load Metrics (1371 ± 22 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint821049063
domContentLoaded1294141313543416
load1294148513714722
domInteractive1294141313543416
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 344661 bytes
  • ui: 12061 bytes
  • common: -10740 bytes

legobeat
legobeat previously approved these changes Apr 21, 2023
@danjm
Copy link
Contributor Author

danjm commented Apr 26, 2023

blocked by #18302

@brad-decker
Copy link
Contributor

@danjm we can close this, #18302 includes trezor update

@danjm
Copy link
Contributor Author

danjm commented Apr 26, 2023

closing in favour of #18302

@danjm danjm closed this Apr 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants