-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: normalize separator in content
on the viewport
meta
tag
#26268
Conversation
content
on the viewport
meta
tagcontent
on the viewport
meta
tag
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #26268 +/- ##
========================================
Coverage 69.95% 69.95%
========================================
Files 1411 1411
Lines 49972 49972
Branches 13801 13801
========================================
Hits 34953 34953
Misses 15019 15019 ☔ View full report in Codecov by Sentry. |
Builds ready [3b92882]
Page Load Metrics (566 ± 423 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirm the problem on the webpack branch when I run
yarn webpack --env production --no-lavamoat
but the problem does not appear on just yarn webpack
, I guess it doesn't get minified
The functionality is the same as before, but it this change works around a bug in https://github.com/terser/html-minifier-terser which causes the space to be removed, and the tag to become invalid (this only affects the webpack build).
Upstream issues:
webdiscus/html-bundler-webpack-plugin#106
terser/html-minifier-terser#178