Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: normalize separator in content on the viewport meta tag #26268

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

davidmurdoch
Copy link
Contributor

@davidmurdoch davidmurdoch commented Jul 31, 2024

The functionality is the same as before, but it this change works around a bug in https://github.com/terser/html-minifier-terser which causes the space to be removed, and the tag to become invalid (this only affects the webpack build).

Upstream issues:

webdiscus/html-bundler-webpack-plugin#106
terser/html-minifier-terser#178

@davidmurdoch davidmurdoch changed the title fix: normalize separator in content on the viewport meta tag chore: normalize separator in content on the viewport meta tag Jul 31, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.95%. Comparing base (e00863e) to head (3b92882).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #26268   +/-   ##
========================================
  Coverage    69.95%   69.95%           
========================================
  Files         1411     1411           
  Lines        49972    49972           
  Branches     13801    13801           
========================================
  Hits         34953    34953           
  Misses       15019    15019           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [3b92882]
Page Load Metrics (566 ± 423 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint8240616811053
domContentLoaded977312210
load442759566882423
domInteractive977312210
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@davidmurdoch davidmurdoch marked this pull request as ready for review July 31, 2024 23:09
@davidmurdoch davidmurdoch requested review from kumavis and a team as code owners July 31, 2024 23:09
Copy link
Contributor

@HowardBraham HowardBraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm the problem on the webpack branch when I run
yarn webpack --env production --no-lavamoat
but the problem does not appear on just yarn webpack, I guess it doesn't get minified

@davidmurdoch davidmurdoch merged commit 6b592c5 into develop Aug 2, 2024
87 checks passed
@davidmurdoch davidmurdoch deleted the fix-user-scalable-no branch August 2, 2024 22:10
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2024
@metamaskbot metamaskbot added the release-12.4.0 Issue or pull request that will be included in release 12.4.0 label Aug 2, 2024
@gauthierpetetin gauthierpetetin added release-12.3.0 Issue or pull request that will be included in release 12.3.0 and removed release-12.4.0 Issue or pull request that will be included in release 12.4.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants