Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: integrate multichainAssetsController #30059

Merged
merged 17 commits into from
Feb 7, 2025

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Feb 3, 2025

Description

PR to integrate the new MultichainAssetsController into metamask controller.

Open in GitHub Codespaces

Related issues

Fixes:

Related: MetaMask/core#5138

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Feb 3, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri marked this pull request as ready for review February 6, 2025 17:46
zone-live
zone-live previously approved these changes Feb 6, 2025
ui/selectors/selectors.js Outdated Show resolved Hide resolved
salimtb
salimtb previously approved these changes Feb 6, 2025
@sahar-fehri sahar-fehri dismissed stale reviews from salimtb and zone-live via 8a0a1db February 6, 2025 18:12
salimtb
salimtb previously approved these changes Feb 6, 2025
zone-live
zone-live previously approved these changes Feb 6, 2025
ui/selectors/selectors.js Outdated Show resolved Hide resolved
@sahar-fehri sahar-fehri dismissed stale reviews from zone-live and salimtb via 77910a0 February 7, 2025 09:21
ccharly
ccharly previously approved these changes Feb 7, 2025
zone-live
zone-live previously approved these changes Feb 7, 2025
@sahar-fehri sahar-fehri enabled auto-merge February 7, 2025 09:42
@sahar-fehri sahar-fehri dismissed stale reviews from zone-live and ccharly via 1c712fc February 7, 2025 13:48
ccharly
ccharly previously approved these changes Feb 7, 2025
@sahar-fehri sahar-fehri added this pull request to the merge queue Feb 7, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [4dd59cc]
Page Load Metrics (1622 ± 50 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint51018291575263126
domContentLoaded1451175915999345
load14581831162210450
domInteractive2483422110
backgroundConnect96824199
firstReactRender1583372512
getState45613168
initialActions01000
loadScripts1022132011688641
setupStore76019199
uiStartup16662521188218890
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 605 Bytes (0.01%)
  • ui: 0 Bytes (0.00%)
  • common: 65 Bytes (0.00%)

Merged via the queue into main with commit c9c2bf8 Feb 7, 2025
72 checks passed
@sahar-fehri sahar-fehri deleted the feat/integrate-multichain-assets-controller branch February 7, 2025 15:24
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2025
@metamaskbot metamaskbot added the release-12.13.0 Issue or pull request that will be included in release 12.13.0 label Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.13.0 Issue or pull request that will be included in release 12.13.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants