chore: remove EVM-specific code and update bridge types #30078

micaelae · 2025-02-03T22:06:59Z

Description

Changes

enables solana support based on bridge feature flags
adds mutlichain utils to remove EVM assumptions when processing bridge-api requests and responses
- replaces dec->hex chainId conversions with a formatter util
- replaces hex->dec chainId conversions with a formatter util
- only lowercase EVM addresses bc solana is case-sensitive
adds solana native asset definition
assumes that MC network config will be similar to NetworkConfiguration

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMS-1845

Manual testing steps

Verify that there are no changes to EVM e2e flows
If solana account is active, Swap and Bridge buttons should be disabled
Load Flask build and activate solana account
5. Swap button should link to Bridge experience
6. Bridge button should link to Bridge experience
4. solana should be set as the bridge src network if a solana account is active

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

metamaskbot · 2025-02-03T22:42:06Z

Builds ready [3a1bbf2]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1827 ± 96 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1516	2215	1824	200	96
		domContentLoaded	1466	2207	1792	195	94
		load	1518	2219	1827	201	96
		domInteractive	27	122	48	30	14
		backgroundConnect	10	69	32	22	11
		firstReactRender	16	94	38	25	12
		getState	5	62	22	21	10
		initialActions	0	1	0	0	0
		loadScripts	1050	1651	1329	171	82
		setupStore	8	69	19	20	10
		uiStartup	1714	2607	2119	242	116

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 254 Bytes (0.00%)
ui: 201 Bytes (0.00%)
common: 1.49 KiB (0.02%)

metamaskbot · 2025-02-05T02:18:57Z

Builds ready [610c9f9]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1670 ± 40 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1543	1882	1671	84	40
		domContentLoaded	1497	1867	1649	85	41
		load	1545	1880	1670	84	40
		domInteractive	19	122	43	27	13
		backgroundConnect	12	65	26	17	8
		firstReactRender	16	80	36	24	12
		getState	4	51	9	10	5
		initialActions	0	1	0	0	0
		loadScripts	1057	1396	1197	78	37
		setupStore	8	60	23	21	10
		uiStartup	1715	2414	1926	144	69

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 299 Bytes (0.00%)
ui: 2.48 KiB (0.03%)
common: 2.1 KiB (0.02%)

metamaskbot · 2025-02-05T23:31:18Z

Builds ready [ad7091c]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1655 ± 79 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1439	2127	1658	163	78
		domContentLoaded	1432	2034	1631	152	73
		load	1440	2129	1655	165	79
		domInteractive	24	69	34	10	5
		backgroundConnect	10	100	34	24	11
		firstReactRender	16	78	37	24	11
		getState	4	47	10	9	4
		initialActions	0	1	0	0	0
		loadScripts	991	1477	1168	119	57
		setupStore	8	62	15	15	7
		uiStartup	1655	2323	1886	166	80

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 299 Bytes (0.00%)
ui: 2.48 KiB (0.03%)
common: 2.1 KiB (0.02%)

metamaskbot · 2025-02-06T02:23:12Z

Builds ready [3e0753b]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1957 ± 101 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	350	2443	1882	413	198
		domContentLoaded	1589	2342	1926	209	100
		load	1601	2360	1957	210	101
		domInteractive	26	125	50	24	12
		backgroundConnect	12	77	29	20	10
		firstReactRender	17	100	44	28	14
		getState	4	72	28	25	12
		initialActions	0	1	0	0	0
		loadScripts	1111	1734	1412	166	80
		setupStore	8	89	27	25	12
		uiStartup	1844	2936	2302	307	147

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 299 Bytes (0.00%)
ui: 3.24 KiB (0.04%)
common: 2.1 KiB (0.02%)

metamaskbot · 2025-02-06T19:40:24Z

Builds ready [a505087]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1827 ± 84 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	291	2191	1757	376	181
		domContentLoaded	1525	2128	1790	163	78
		load	1545	2196	1827	174	84
		domInteractive	23	88	38	16	8
		backgroundConnect	11	86	43	24	12
		firstReactRender	17	94	35	23	11
		getState	5	61	23	18	9
		initialActions	0	1	0	0	0
		loadScripts	1078	1627	1302	150	72
		setupStore	7	53	16	14	7
		uiStartup	1808	2501	2129	210	101

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 299 Bytes (0.00%)
ui: 3.24 KiB (0.04%)
common: 2.1 KiB (0.02%)

The base branch was changed.

micaelae · 2025-02-06T23:28:15Z

ui/pages/bridge/prepare/prepare-bridge-page.tsx

      // This override allows quotes to be returned when the rpcUrl is a tenderly fork
      // Otherwise quotes get filtered out by the bridge-api when the wallet's real
      // balance is less than the tenderly balance
      insufficientBal: Boolean(providerConfig?.rpcUrl?.includes('tenderly')),
      slippage,
+      walletAddress:
+        fromChain?.chainId && isCaipChainId(fromChain.chainId)


use explicit non-evm check

metamaskbot · 2025-02-07T01:02:29Z

Builds ready [ab0ab94]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1730 ± 54 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1563	2060	1737	108	52
		domContentLoaded	1546	2038	1704	107	51
		load	1556	2065	1730	112	54
		domInteractive	25	98	44	20	10
		backgroundConnect	11	76	33	22	11
		firstReactRender	15	93	32	24	12
		getState	4	53	13	13	6
		initialActions	0	1	0	0	0
		loadScripts	1094	1484	1239	88	42
		setupStore	7	61	23	22	10
		uiStartup	1725	2354	1977	148	71

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 299 Bytes (0.00%)
ui: 3.16 KiB (0.04%)
common: 2.1 KiB (0.02%)

chore: rm lowercased addresses

metamaskbot · 2025-02-07T21:05:08Z

Builds ready [fdce791]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1643 ± 53 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1498	1935	1638	111	53
		domContentLoaded	1485	1918	1608	109	52
		load	1499	1933	1643	111	53
		domInteractive	25	174	45	35	17
		backgroundConnect	10	86	36	23	11
		firstReactRender	15	67	28	18	9
		getState	6	51	23	17	8
		initialActions	0	1	0	0	0
		loadScripts	1052	1427	1161	91	44
		setupStore	7	54	13	13	6
		uiStartup	1659	2174	1856	118	57

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 299 Bytes (0.00%)
ui: 2.24 KiB (0.03%)
common: 2.1 KiB (0.02%)

micaelae force-pushed the mms1845-swaps-sol-base branch from 683d792 to 6669a10 Compare February 5, 2025 00:53

micaelae added the team-bridge label Feb 5, 2025

micaelae changed the title ~~chore: update bridge controllers and types to support multichain networks~~ chore: remove EVM-specific code and update bridge types Feb 5, 2025

micaelae force-pushed the mms1845-swaps-sol-base branch from e7b15c1 to 787948a Compare February 6, 2025 01:21

micaelae marked this pull request as ready for review February 6, 2025 01:31

micaelae requested a review from a team as a code owner February 6, 2025 01:31

ghgoodreau previously approved these changes Feb 6, 2025

View reviewed changes

micaelae dismissed ghgoodreau’s stale review via a505087 February 6, 2025 19:01

micaelae force-pushed the mms1845-swaps-sol-base branch from 3e0753b to a505087 Compare February 6, 2025 19:01

ghgoodreau previously approved these changes Feb 6, 2025

View reviewed changes

micaelae changed the base branch from main to mms-1867-fix-bridge-header February 6, 2025 19:51

micaelae changed the base branch from mms-1867-fix-bridge-header to main February 6, 2025 19:51

micaelae commented Feb 6, 2025

View reviewed changes

micaelae added 10 commits February 7, 2025 12:25

chore: add default native token for Solana

d248102

chore: read solana FF from api

beb846e

chore: include solana in src/dest network list

ac96ac0

fix: display image of SOL token

22cceec

chore: multichain utils

1308601

chore: wrap chainId conversions in bridge components

8b6d4dc

chore: wrap chainId conversions in transaction-details

7499e56

chore: wrap chainId conversions in tx submission

a3d9b8e

chore: wrap chainId conversions in bridge hooks

1676bfe

chore: wrap chainId conversions in bridge ducks

91323ae

micaelae added 14 commits February 7, 2025 12:25

chore: shared bridge utils

5aaa092

chore: bridge-status utils

49589ec

chore: bridge controller

5021794

header

e5743db

chore: rm lowercased addresses

fix: bridge quote request params

20e8cdc

fix: non-flask build

808b720

refactor: rename chainId formatter utils

a0cc776

chore: remove usages of MultichainProviderConfig

9baec32

fix: unit tests

eb7bf57

fix: set bridge src token from url param

4c6a127

fix: lint issue

14318a0

fix: snapshot tests

ae41d26

chore: deprecate BridgeLinkClicked event

d6add6e

chore: rm unnecessary walletAddress condition

fdce791

micaelae force-pushed the mms1845-swaps-sol-base branch from ab0ab94 to fdce791 Compare February 7, 2025 20:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: remove EVM-specific code and update bridge types #30078

chore: remove EVM-specific code and update bridge types #30078

micaelae commented Feb 3, 2025 •

edited

Loading

metamaskbot commented Feb 3, 2025

metamaskbot commented Feb 5, 2025

metamaskbot commented Feb 5, 2025

metamaskbot commented Feb 6, 2025

metamaskbot commented Feb 6, 2025

micaelae Feb 6, 2025

metamaskbot commented Feb 7, 2025

metamaskbot commented Feb 7, 2025

chore: remove EVM-specific code and update bridge types #30078

Are you sure you want to change the base?

chore: remove EVM-specific code and update bridge types #30078

Conversation

micaelae commented Feb 3, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

metamaskbot commented Feb 3, 2025

metamaskbot commented Feb 5, 2025

metamaskbot commented Feb 5, 2025

metamaskbot commented Feb 6, 2025

metamaskbot commented Feb 6, 2025

micaelae Feb 6, 2025

Choose a reason for hiding this comment

metamaskbot commented Feb 7, 2025

metamaskbot commented Feb 7, 2025

micaelae commented Feb 3, 2025 •

edited

Loading