feat: auth & profile sync logic improvements

[mathieuartu]

Description

This PR improves the overall logic behind auth & profile syncing.

Changelog:

• Bump @metamask/profile-sync-controller to v6.0.0 and @metamask/notification-services-controller to v0.19.0
• Add new useSignOut hook to programmatically sign users out
• Refactor the useAutoSignIn hook so it encapsulates all automatic sign in logic.
• Remove all sign-out calls except for when basic functionality is turned off. Signing out should and will only happen when basic functionality is turned off.
• Create new useAutoSignOut hook to manage automatic sign outs.
• Remove UserStorageController MetaMetrics dependency
• Remove notification related actions from UserStorageController allowedActions
• Remove the capability for NotificationServicesController to enable profile syncing
• Remove the profile syncing dependency for notifications. They only rely on Auth & user storage. Profile syncing is an umbrella term that encompasses only Account syncing for now.

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/IDENTITY-18

Manual testing steps

1. Do a fresh onboarding and verify that by default you are signed in when finishing (/login call in the network tab)
2. Do a fresh onboarding, disable basic functionality in the onboarding settings and verify that:
   1. Profile syncing toggle is turned off
   2. Complete onboarding and verify that you're not signed in (no /login call in the network tab)
3. Finish onboarding
4. Go to the settings page
   1. Disable profile syncing
   2. Enable notifications
   3. Verify that notifications work
   4. Verify that the profile syncing setting was not automatically turned on
5. Go to the settings page
   1. Turn basic functionality off
   2. Turn basic functionality on
   3. Turn any auth dependent feature on (MetaMetrics, Profile Syncing, Notifications...)
   4. Verify that you see a /login call in the network tab

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[socket-security]

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected]	None	+1	840 kB	danfinlay, gudahtt, kumavis, ...6 more
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected]	None	0	178 kB	danfinlay, gudahtt, kumavis, ...6 more
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected]	None	0	543 kB	danfinlay, gudahtt, kumavis, ...6 more
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected]	None	0	1.38 MB	metamaskbot
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected]	network Transitive: environment	+1	2.27 MB	metamaskbot

View full report↗︎

[socket-security]

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert	Package	Note	Source	CI
Network access	npm/@metamask/[email protected]	Module: globalThis["fetch"] Location: Package overview	package.json yarn.lock	🚫

View full report↗︎

Next steps

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

• @SocketSecurity ignore npm/@metamask/[email protected]

[mathieuartu]

@metamaskbot update-policies

[metamaskbot]

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

[metamaskbot]

Builds ready [592b8ec]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1926 ± 64 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	536	2109	1865	333	160
		domContentLoaded	1605	2100	1897	134	64
		load	1623	2106	1926	133	64
		domInteractive	28	105	45	22	11
		backgroundConnect	10	78	36	23	11
		firstReactRender	18	92	45	25	12
		getState	7	61	13	11	5
		initialActions	0	1	0	0	0
		loadScripts	1140	1547	1392	106	51
		setupStore	10	64	28	22	11
		uiStartup	1877	2414	2192	140	67

Bundle size diffs [🚀 Bundle size reduced!]

• background: -858 Bytes (-0.01%)
• ui: 1.79 KiB (0.02%)
• common: -6.85 KiB (-0.07%)

[metamaskbot]

Builds ready [8de24e0]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1619 ± 73 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	444	2116	1566	302	145
		domContentLoaded	1429	2059	1597	149	71
		load	1437	2066	1619	152	73
		domInteractive	16	72	41	19	9
		backgroundConnect	7	70	29	22	10
		firstReactRender	15	103	38	30	14
		getState	4	55	11	14	7
		initialActions	0	1	0	0	0
		loadScripts	998	1565	1141	134	64
		setupStore	6	88	19	22	11
		uiStartup	1628	2686	1871	243	117

Bundle size diffs [🚀 Bundle size reduced!]

• background: -817 Bytes (-0.01%)
• ui: 1.67 KiB (0.02%)
• common: -6.85 KiB (-0.07%)