Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removing more unused css #30217

Merged
merged 1 commit into from
Feb 11, 2025
+1 −98
Merged

chore: removing more unused css #30217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .storybook/test-data.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1859,7 +1859,7 @@ export const networkList = [
{
blockExplorerUrl: 'https://etherscan.io',
chainId: '0x1',
iconColor: 'var(--mainnet)',
iconColor: 'var(--color-primary-default)',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating storybook test data not used in prod

isATestNetwork: false,
labelKey: 'mainnet',
providerType: 'mainnet',
Expand Down
53 changes: 0 additions & 53 deletions ui/css/base-styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,18 +43,6 @@ html {
}
}

/*
This error class is used in the following files still:
/ui/pages/create-account/import-account/json.js
/ui/pages/create-account/import-account/private-key.js
*/
.error {
color: var(--color-error-default);
margin-top: 3px;
margin-bottom: 9px;
overflow-wrap: anywhere;
}

Comment on lines -46 to -57
Copy link
Contributor Author

@georgewrmarshall georgewrmarshall Feb 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error className is not used. I checked both json.js and private-key.js. Additionally, using the regex

className=["'{`][^"'`}]*error[^"'`}]*["'}`]

to search for instances of error in a className prop returned no exact matches.

Screenshot 2025-02-07 at 2 56 02 PM

/* stylelint-disable */
#app-content {
overflow-x: hidden;
Expand Down Expand Up @@ -83,47 +71,6 @@ a:hover {
color: var(--color-primary-alternative);
}

.input-label {
padding-bottom: 10px;
font-weight: 400;
display: inline-block;
}

input.form-control {
padding-left: 10px;
font-size: 14px;
height: 40px;
border: 1px solid var(--color-border-default);
color: 1px solid var(--color-text-default);
background: transparent;
border-radius: 3px;
width: 100%;

&::-webkit-input-placeholder {
font-weight: 100;
color: var(--color-text-muted);
}

&::-moz-placeholder {
font-weight: 100;
color: var(--color-text-muted);
}

&:-ms-input-placeholder {
font-weight: 100;
color: var(--color-text-muted);
}

&:-moz-placeholder {
font-weight: 100;
color: var(--color-text-muted);
}

&--error {
border: 1px solid var(--color-error-default);
}
}

/** Default Typography on base elements **/
* {
font-family: design-system.$font-family;
Expand Down
1 change: 0 additions & 1 deletion ui/css/design-system/_colors.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ $color-map: (
'info-default': --color-info-default,
'info-muted': --color-info-muted,
'info-inverse': --color-info-inverse,
'mainnet': --mainnet,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer used

'goerli': --color-network-goerli-default,
'sepolia': --color-network-sepolia-default,
'goerli-inverse':--color-network-goerli-inverse,
Expand Down
1 change: 0 additions & 1 deletion ui/css/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
overtime.
*/
@import './itcss/settings/index';
@import './itcss/tools/index';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing deleted file import

@import './itcss/components/index';

/*
Expand Down
1 change: 0 additions & 1 deletion ui/css/itcss/tools/index.scss
View file
Open in desktop

This file was deleted.

37 changes: 0 additions & 37 deletions ui/css/itcss/tools/utilities.scss
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions ui/css/utilities/colors.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ Before adding a color here make sure that there isn't a design token available.
*/
/* stylelint-disable color-no-hex */
:root {
// Accents
// Everything below this line is part of the new color system
--mainnet: #29b6af;
Comment on lines -7 to -9
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing unused --mainnet CSS variable

Screenshot 2025-02-07 at 3 00 37 PM

--inherit: inherit;
--transparent: transparent;
// DO NOT CHANGE
Expand Down
1 change: 0 additions & 1 deletion ui/helpers/constants/design-system.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ export enum Color {
infoDefault = 'info-default',
infoMuted = 'info-muted',
infoInverse = 'info-inverse',
mainnet = 'mainnet',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing from Color enum as it is not used

Screenshot 2025-02-07 at 3 01 12 PM

goerli = 'goerli',
sepolia = 'sepolia',
lineaGoerli = 'linea-goerli',
Expand Down
Loading