-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: adding appear animations to modal dialog and overlay #30258
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
@@ -34,6 +34,8 @@ | |||
|
|||
max-height: 100%; | |||
box-shadow: var(--shadow-size-lg) var(--color-shadow-default); | |||
animation: mm-modal-slide-up 400ms cubic-bezier(0.3, 0.8, 0.3, 1) forwards; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add prefers reduced motion media query to remove the animation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the addition of the media query for reduced motion
06a2050
to
fff51b1
Compare
Builds ready [fff51b1]
Page Load Metrics (1642 ± 97 ms)
Bundle size diffs
|
Description
This PR adds entrance animations to our modal components while ensuring accessibility through proper motion reduction support. The changes include:
Modal Content Animation:
Modal Overlay Animation:
Accessibility Considerations:
prefers-reduced-motion
These enhancements make our modals feel more polished while maintaining accessibility standards.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4047
Manual testing steps
Testing Modal Motion
Modal
Testing Prefers Reduced Motion
prefers reduced-motion
Screenshots/Recordings
Before
Modal appears instantly without animation
before720.mov
After
Modal fades and slides in smoothly but removes animation when
prefers-reduced-motion
is enabledmodal.after720.mov
Pre-merge author checklist
Pre-merge reviewer checklist