fix: cp-12.12.0 improve token list rendering

[Prithpal-Sooriya]

Description

The token list is an expensive component that renders many tokens. We found this suite of components to not be optimised, and the selector it relied on to always return new data (causing unnecessary re-renders).

This optimises some controllers and selectors to prevent unnecessary and expensive re-renders.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4022

Manual testing steps

1. Follow instructions in issue
2. Click "Send" button. Does it load (not take ages as seen in the video)

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [73fc33b]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1499 ± 40 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1365	1673	1499	86	41
		domContentLoaded	1352	1659	1476	84	40
		load	1367	1671	1499	83	40
		domInteractive	22	76	35	20	9
		backgroundConnect	10	50	22	14	7
		firstReactRender	14	98	43	29	14
		getState	4	58	9	11	5
		initialActions	0	1	0	0	0
		loadScripts	939	1201	1063	76	37
		setupStore	6	50	12	12	6
		uiStartup	1530	2175	1727	168	81

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 0 Bytes (0.00%)
• ui: 905 Bytes (0.01%)
• common: 21 Bytes (0.00%)