Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump @metamask/api-specs to ^0.10.15 #30273

Merged
merged 7 commits into from
Feb 14, 2025
Merged

Conversation

jiexi
Copy link
Contributor

@jiexi jiexi commented Feb 12, 2025

Description

Bumps @metamask/api-specs to ^0.10.15

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jiexi jiexi marked this pull request as ready for review February 12, 2025 18:47
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [644c5a9]
Page Load Metrics (1621 ± 38 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1477184816248742
domContentLoaded1471177616038239
load1475178316218038
domInteractive2595442612
backgroundConnect86524189
firstReactRender1695492612
getState545994
initialActions01000
loadScripts1021134111477636
setupStore781222411
uiStartup17162347188215474
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@Gudahtt
Copy link
Member

Gudahtt commented Feb 12, 2025

Nit: probably "chore" is the better description of this change than "feat". Unless this adds some platform feature/capability for contributors? Some detail on that in the PR description would be appreciated if so.

Gudahtt
Gudahtt previously approved these changes Feb 12, 2025
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jiexi jiexi changed the title feat: bump @metamask/api-specs to ^0.10.15 chore: bump @metamask/api-specs to ^0.10.15 Feb 12, 2025
Copy link

socket-security bot commented Feb 12, 2025

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected] None 0 294 kB metamaskbot

View full report↗︎

@jiexi
Copy link
Contributor Author

jiexi commented Feb 12, 2025

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

@metamaskbot metamaskbot requested review from a team as code owners February 12, 2025 23:39
@metamaskbot
Copy link
Collaborator

Builds ready [2c016f9]
Page Load Metrics (1538 ± 36 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1400170715397436
domContentLoaded1395169615137134
load1408171015387536
domInteractive22123402713
backgroundConnect96027189
firstReactRender1488382713
getState47614199
initialActions01000
loadScripts969129910877335
setupStore65215157
uiStartup16002131177911957
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 7.28 KiB (0.08%)

@Gudahtt Gudahtt added this pull request to the merge queue Feb 14, 2025
Merged via the queue into main with commit 1880f16 Feb 14, 2025
73 checks passed
@Gudahtt Gudahtt deleted the jl/bump-api-specs-0.10.15 branch February 14, 2025 14:25
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2025
@metamaskbot metamaskbot added the release-12.14.0 Issue or pull request that will be included in release 12.14.0 label Feb 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.14.0 Issue or pull request that will be included in release 12.14.0 team-wallet-api-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants