Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use useCallback for domain input in Send flow #30880

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Mar 8, 2025

Description

The DomainInput was being re-rendered because the event callbacks weren't using useCallback. This PR prevents those re-renders.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to send flow
  2. Ensure pasting into the domain field, typing a valid address, etc. works properly

Screenshots/Recordings

Before

SCR-20250307-stxe

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@darkwing darkwing requested a review from a team as a code owner March 8, 2025 02:27
Copy link
Contributor

github-actions bot commented Mar 8, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [671ee33]
Page Load Metrics (1975 ± 72 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint41423071896371178
domContentLoaded17122217193614369
load17522315197514972
domInteractive27633694
backgroundConnect14105462814
firstReactRender1568342110
getState567232010
initialActions01000
loadScripts13051679147411555
setupStore85515136
uiStartup199130412270266128
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 153 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants