Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable sentry performance reporting on local development builds #11608

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: enable sentry performance reporting on local development builds #11608

wants to merge 4 commits into from
+4 −2

Conversation

joaoloureirop
Copy link
Contributor

@joaoloureirop joaoloureirop commented Oct 3, 2024 •
edited
Loading

Description

Allow local development builds to send Sentry performance transactions

Related issues

Fixes: https://github.com/MetaMask/mobile-planning/issues/1919

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@joaoloureirop joaoloureirop marked this pull request as ready for review October 10, 2024 15:37
@joaoloureirop joaoloureirop requested a review from a team as a code owner October 10, 2024 15:37
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@joaoloureirop joaoloureirop added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 16, 2024
@joaoloureirop joaoloureirop self-assigned this Oct 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 16, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: fb64a38
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/db721f17-7b6a-4d90-ac4a-6c21f17ee270

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@legobeat
Copy link
Contributor

Is it still possible to build & test locally without a valid Sentry token?

@joaoloureirop
Copy link
Contributor Author

Is it still possible to build & test locally without a valid Sentry token?

Yes.

The absence of a valid Sentry key will only prevent Sentry from initializing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joaoloureirop joaoloureirop

Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
PR review queue
Status: Needs dev review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joaoloureirop @legobeat