Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sort/Import Tokens in Mobile #11618

Open
wants to merge 30 commits into
base: feat/mmassets_357-sort-import-tokens-mobile--reorg-portfolio-balance
Choose a base branch
from

Conversation

gambinish
Copy link
Contributor

@gambinish gambinish commented Oct 4, 2024

Description

Implements Token Sorting on mobile. This is the mobile implementation of the same feature on extension: MetaMask/metamask-extension#27184

Note that this currently includes a patch of the PreferencesController. There is a corresponding PR in core to add this to a formal controller release: MetaMask/core#4747

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMASSETS-357

Manual testing steps

Go to Portfolio Screen
Sort should allow sorting by declining fiat balance by default. Users can then toggle and sort alphabetically or by declining fiat balance.

Import button should function the same as the import token link in footer

Screenshots/Recordings

Screen.Recording.2024-10-03.at.10.37.36.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@gambinish gambinish added the No QA Needed Apply this label when your PR does not need any QA effort. label Oct 4, 2024
Copy link
Contributor

github-actions bot commented Oct 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gambinish gambinish added DO-NOT-MERGE Pull requests that should not be merged and removed team-assets labels Oct 4, 2024
@gambinish gambinish changed the title Feat/mmassets 357 sort import tokens mobile token sort config feat: Token Sorting feature 🚧 Oct 4, 2024
@gambinish gambinish changed the base branch from main to feat/mmassets_357-sort-import-tokens-mobile--reorg-portfolio-balance October 4, 2024 05:49
@gambinish gambinish added Run Smoke E2E Triggers smoke e2e on Bitrise and removed No QA Needed Apply this label when your PR does not need any QA effort. labels Oct 8, 2024
Copy link
Contributor

github-actions bot commented Oct 8, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 469270a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/83984131-4359-4325-994c-3acef36b35d8

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@gambinish gambinish marked this pull request as ready for review October 9, 2024 19:02
@gambinish gambinish requested review from a team as code owners October 9, 2024 19:02
@gambinish gambinish added Run Smoke E2E Triggers smoke e2e on Bitrise team-assets and removed DO-NOT-MERGE Pull requests that should not be merged Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 9, 2024
Copy link
Contributor

github-actions bot commented Oct 9, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 82eb1a2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/99bce5c6-c156-41dd-a52d-7c5f85e00089

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@legobeat legobeat marked this pull request as draft October 10, 2024 20:24
@legobeat legobeat changed the title feat: Token Sorting feature 🚧 feat: Token Sorting feature Oct 10, 2024
@gambinish gambinish added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 15, 2024
Copy link
Contributor

github-actions bot commented Oct 15, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1d929ce
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e4142e7a-e9b7-4ebd-a8c5-ef55e483929c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@gambinish gambinish added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 16, 2024
Copy link
Contributor

github-actions bot commented Oct 16, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 63bb1a2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d2b32f4a-e044-4677-bef5-023583c77a36

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

gambinish and others added 2 commits October 16, 2024 09:24
…folio-balance' into feat/mmassets_357-sort-import-tokens-mobile--token-sort-config
@gambinish gambinish added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 16, 2024
Copy link
Contributor

github-actions bot commented Oct 16, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: bd9ad0d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1ed7f7fe-b4ad-47c2-bdfd-197dca482d54

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 69.44444% with 11 lines in your changes missing coverage. Please review.

Please upload report for BASE (feat/mmassets_357-sort-import-tokens-mobile--reorg-portfolio-balance@96436be). Learn more about missing BASE report.

Files with missing lines Patch % Lines
app/components/UI/Tokens/index.tsx 67.74% 9 Missing and 1 partial ⚠️
app/actions/settings/index.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                                           Coverage Diff                                           @@
##             feat/mmassets_357-sort-import-tokens-mobile--reorg-portfolio-balance   #11618   +/-   ##
=======================================================================================================
  Coverage                                                                        ?   54.34%           
=======================================================================================================
  Files                                                                           ?     1714           
  Lines                                                                           ?    39129           
  Branches                                                                        ?     4849           
=======================================================================================================
  Hits                                                                            ?    21263           
  Misses                                                                          ?    16377           
  Partials                                                                        ?     1489           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…folio-balance' into feat/mmassets_357-sort-import-tokens-mobile--token-sort-config
@gambinish gambinish added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 17, 2024
Copy link
Contributor

github-actions bot commented Oct 17, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: c0a28bc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bd6b1bfc-c223-488f-bf26-f9862f02be34

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

…folio-balance' into feat/mmassets_357-sort-import-tokens-mobile--token-sort-config
@gambinish gambinish added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 17, 2024
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 8cb67f7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9613b40a-de89-4934-8d59-3a964693ecfb

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Oct 17, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
Status: Review finalised - Ready to be merged
Development

Successfully merging this pull request may close these issues.

4 participants