-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Sort/Import Tokens in Mobile #11618
base: feat/mmassets_357-sort-import-tokens-mobile--reorg-portfolio-balance
Are you sure you want to change the base?
feat: Sort/Import Tokens in Mobile #11618
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise❌❌❌ Commit hash: 469270a Note
Tip
|
Bitrise❌❌❌ Commit hash: 82eb1a2 Note
Tip
|
Bitrise✅✅✅ Commit hash: 1d929ce Note
|
Bitrise✅✅✅ Commit hash: 63bb1a2 Note
|
…folio-balance' into feat/mmassets_357-sort-import-tokens-mobile--token-sort-config
Bitrise✅✅✅ Commit hash: bd9ad0d Note
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/mmassets_357-sort-import-tokens-mobile--reorg-portfolio-balance #11618 +/- ##
=======================================================================================================
Coverage ? 54.34%
=======================================================================================================
Files ? 1714
Lines ? 39129
Branches ? 4849
=======================================================================================================
Hits ? 21263
Misses ? 16377
Partials ? 1489 ☔ View full report in Codecov by Sentry. |
…folio-balance' into feat/mmassets_357-sort-import-tokens-mobile--token-sort-config
Bitrise✅✅✅ Commit hash: c0a28bc Note
|
…folio-balance' into feat/mmassets_357-sort-import-tokens-mobile--token-sort-config
Bitrise🔄🔄🔄 Commit hash: 8cb67f7 Note
|
Quality Gate passedIssues Measures |
Description
Implements Token Sorting on mobile. This is the mobile implementation of the same feature on extension: MetaMask/metamask-extension#27184
Note that this currently includes a patch of the
PreferencesController
. There is a corresponding PR in core to add this to a formal controller release: MetaMask/core#4747Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/MMASSETS-357
Manual testing steps
Go to Portfolio Screen
Sort should allow sorting by declining fiat balance by default. Users can then toggle and sort alphabetically or by declining fiat balance.
Import button should function the same as the import token link in footer
Screenshots/Recordings
Screen.Recording.2024-10-03.at.10.37.36.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist