-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(2794): account edit permission, permission list initialization, edit, and submit #11748
base: main
Are you sure you want to change the base?
feat(2794): account edit permission, permission list initialization, edit, and submit #11748
Conversation
… back are feature complete, feature flag removed, dead code removed, and ready to write new tests
…y, this is the case where the user is on the connectMore screen
…playing, and hide irrelevant text or select all checkbox
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…er than closing the bottom sheet. On initial connect, clicking the confirm button navs back to summary without submiting, the summary has a button to submit. On connected flow, in this case it submits before naviging back to summary, a toast is also shown as usual.
Bitrise✅✅✅ Commit hash: 1a04123 Note
|
Quality Gate passedIssues Measures |
Description
This PR adds the ability to edit account permissions for in app browser dapps.
Related issues
Contributes to solve issue: https://github.com/MetaMask/MetaMask-planning/issues/2796
Manual testing steps
I have added screenshot below to see how it looks.
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist