-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix the mobile crash due to ledger bluetooth relative exception #11769
base: main
Are you sure you want to change the base?
Conversation
…er instead of close screen directly.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise✅✅✅ Commit hash: 959d553 Note
|
Implement the Unit tests to cover the difference condition in the test.
Bitrise✅✅✅ Commit hash: e897d88 Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Bitrise✅✅✅ Commit hash: 4cb6176 Note
|
Quality Gate passedIssues Measures |
Tested on Bitrise build Android and iOS, working as expected |
Description
This PR will fix the mobile crash issue when user disable the blind signing and reject the transaction in ledger devices.
This PR create a global exception handler to handle the bluetooth relative exception throw directly from native code, which can't be handled by our javascript code, (useLedgerBluetooth.ts has code handle those exception but shomehow, the exception still bubble up to
ExceptionHandler
in react native core which cause the red screen and app crash).The global exception will specially handle the Ledger relative exception and stop exception bubble to react native core to stop app crash.
Related issues
Fixes: #11166
#11216
Manual testing steps
Screenshots/Recordings
Before
https://api.zenhub.com/attachedFiles/eyJfcmFpbHMiOnsibWVzc2FnZSI6IkJBaHBBenN6Qnc9PSIsImV4cCI6bnVsbCwicHVyIjoiYmxvYl9pZCJ9fQ==--8d54ab43db845febde47fa78240c0aff20dbbff9/RPReplay_Final1728461873.MP4
After
Pre-merge author checklist
Pre-merge reviewer checklist