chore: upgrade assets controllers v33.0.0

[sahar-fehri]

Description

PR to upgrade assets-controllers to v33.0.0

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Screen.Recording.2024-10-16.at.11.11.34.mov

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/[email protected]	None	+3	2.43 MB	metamaskbot

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9200e03
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7989279e-b38b-4cb0-9832-9eb305c0c010

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 36f889b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/44d473d0-06e0-41cb-9be2-a1c4dcae6e08

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[Daniel-Cross]

Hi @sahar-fehri

When I checkout the branch and cold boot the app I get stuck on a loading screen, see attached:

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-10-16.at.11.21.07.mp4

[Daniel-Cross]

App gets stuck on loading screen on cold boot.

[Daniel-Cross]

Hi @sahar-fehri

When I checkout the branch and cold boot the app I get stuck on a loading screen, see attached:

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-10-16.at.11.21.07.mp4

This is addressed with a clean build of the app so I'll approve.

[Daniel-Cross]

Looks good!

[sahar-fehri]

Thanks @Daniel-Cross for pulling the branch locally and testing it 🙏

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 2edb087
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5f8b6866-d2d5-4c45-8742-db25d297da86

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[sonarcloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud