Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: readd date time picker #11852

Merged
merged 1 commit into from
Oct 17, 2024
Merged

chore: readd date time picker #11852

merged 1 commit into from
Oct 17, 2024

Conversation

cortisiko
Copy link
Member

@cortisiko cortisiko commented Oct 17, 2024

Description

This reverts commit 617185a. The datetime library, used by the DS team, was removed, causing instability in Storybook. This PR aims to revert the commit that removed the library.

Passing E2E: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c36d7fe0-fe0b-49ba-920a-912eb5f1c0e8

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cortisiko cortisiko added No QA Needed Apply this label when your PR does not need any QA effort. team-mobile-platform labels Oct 17, 2024
@cortisiko cortisiko self-assigned this Oct 17, 2024
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@react-native-community/[email protected] None 0 219 kB vonovak

View full report↗︎

Copy link

sonarcloud bot commented Oct 17, 2024

@cortisiko cortisiko marked this pull request as ready for review October 17, 2024 22:29
@cortisiko cortisiko requested review from a team as code owners October 17, 2024 22:29
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cortisiko cortisiko added this pull request to the merge queue Oct 17, 2024
Merged via the queue into main with commit 2ffb4aa Oct 17, 2024
50 of 51 checks passed
@cortisiko cortisiko deleted the readd-date-time-library branch October 17, 2024 23:07
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.34.0 team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants