Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend PickerNetwork component functionality #11856

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vinnyhoward
Copy link
Contributor

Description

This PR changes the PickerNetwork to allow the network name to be hidden. These changes are necessary to accommodate the Header Update design requirements coming up. However the aim is to introduce very little change (other than padding) to what is pre-existing but by passing in the prop of hideNetwork it changes into the future design

Related issues

Related: #11763

Manual testing steps

  1. View any instance of PickerNetwork being used. For example the PickerNetwork in header in the home screen

Screenshots/Recordings

before

After hideNetwork=false the default
after (no prop)

After hideNetwork=true
after (prop)

Before

NA

After

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vinnyhoward vinnyhoward requested review from a team as code owners October 17, 2024 22:59
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vinnyhoward vinnyhoward added team-wallet-ux team-ramp issues related to Ramp features team-design-system All issues relating to design system in Mobile Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 17, 2024
Copy link
Contributor

github-actions bot commented Oct 17, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: e2f4191
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3b0de6ec-0450-46cb-938f-3adce9f84d48

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Oct 17, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-design-system All issues relating to design system in Mobile team-ramp issues related to Ramp features team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant