Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add better default style support for android push notifications #13271

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Prithpal-Sooriya
Copy link
Contributor

Description

This improves the default styles for Android push notifications.

Related issues

Manual testing steps

This currently is not testable as we don't really emit background or killed push notifications (which apply the Android default styles)

Screenshots/Recordings

Before

Screenshot 2025-01-30 at 15 16 44

After

Screenshot 2025-01-29 at 14 42 16

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Prithpal-Sooriya Prithpal-Sooriya requested a review from a team as a code owner January 30, 2025 15:59
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-notifications DEPRECATED: Use "team-assets" instead label Jan 30, 2025
@Prithpal-Sooriya Prithpal-Sooriya added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 30, 2025
Copy link
Contributor

github-actions bot commented Jan 30, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 2a6b94a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3d96b0bd-8fba-4e72-ba9e-a92e55a54615

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-notifications DEPRECATED: Use "team-assets" instead
Projects
Status: Needs dev review
Development

Successfully merging this pull request may close these issues.

2 participants