Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Non evm network global selector #13307

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Conversation

tommasini
Copy link
Contributor

multichain network controllers selectors, network selectors refactor disabled and added TODO for places where non evm network is not supported yet, added feature flag SOLANA_ENABLED that sould be replaced by the code fencing system and should be reviewed, added solana to the network selector, logic to switch network and accounts accordingly to evm an non evm accounts, added solana to network settings

Description

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

… disabled and added TODO for places where non evm network is not supported yet, added feature flag SOLANA_ENABLED that sould be replaced by the code fencing system and should be reviewed, added solana to the network selector, logic to switch network and accounts accordingly to evm an non evm accounts, added solana to network settings
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

…nly evm network related data, this way we can be using evm accounts and networks at confirmations and in app browser without worrying about what is being used at the wallet view
…fix unit tests, remove feature flag, and removed everything from code fence
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-mobile-platform Mobile Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants