fix: Currently keystone lib will throw KeystoneError#Tx_canceled
which will crash the mobile app
#13313
+48
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will fix #13259 issue.
When user reject signature in QR screen, the
@keystonehq/metamask-airgapped-keyring
will throwKeystoneError#Tx_canceled
error. however, for some reason, Hermes engine threat that error as object and go to Crash flow.I have fixed it by adding above uncatch error into our global ErrorHandler.ts to specially thread it.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
Screen.Recording.2025-01-29.at.12.39.27.PM.mov
After
Pre-merge author checklist
Pre-merge reviewer checklist