Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SIWE detection on mobile by patching @spruceid+siwe-parser #13314

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Feb 3, 2025

Description

Fix SIWE detection on mobile by patching @spruceid+siwe-parser
The module is already patched for this issue on extension: MetaMask/metamask-extension#24138

Related issues

Related to: https://github.com/MetaMask/MetaMask-planning/issues/2278
Related to: https://github.com/MetaMask/MetaMask-planning/issues/4076

Manual testing steps

NA

Screenshots/Recordings

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Feb 3, 2025
@jpuri jpuri requested review from a team as code owners February 3, 2025 15:45
Copy link
Contributor

github-actions bot commented Feb 3, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Feb 3, 2025
Copy link
Contributor

github-actions bot commented Feb 3, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: d320960
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1564268a-b693-4b6f-b3cc-9aab2e44a4d8

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

digiwand
digiwand previously approved these changes Feb 3, 2025
@jpuri jpuri enabled auto-merge February 4, 2025 04:42
package.json Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Feb 4, 2025

@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 31ff4ed
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cca38459-a4eb-4234-861a-ecaeafb9a889

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@jpuri jpuri added this pull request to the merge queue Feb 4, 2025
Merged via the queue into main with commit 518eeef Feb 4, 2025
42 of 43 checks passed
@jpuri jpuri deleted the spruceid_patch branch February 4, 2025 12:43
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2025
@metamaskbot metamaskbot added the release-7.41.0 Issue or pull request that will be included in release 7.41.0 label Feb 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.41.0 Issue or pull request that will be included in release 7.41.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants