Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SIWE signature related changes on personal signature page #13329

Open
wants to merge 13 commits into
base: siwe_detection_fix
Choose a base branch
from

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Feb 4, 2025

Description

SIWE signature related changes on personal signature page.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4076

Manual testing steps

  1. Go to test dapp
  2. Submit SIWE and check page that renders

Screenshots/Recordings

Screenshot 2025-02-03 at 7 07 24 PM Screenshot 2025-02-04 at 5 38 15 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Feb 4, 2025
@jpuri jpuri requested review from a team as code owners February 4, 2025 08:41
Copy link
Contributor

github-actions bot commented Feb 4, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri requested a review from a team as a code owner February 4, 2025 10:05
Base automatically changed from spruceid_patch to main February 4, 2025 12:43
@jpuri jpuri added No E2E Smoke Needed If the PR does not need E2E smoke test run Run Smoke E2E Triggers smoke e2e on Bitrise and removed No E2E Smoke Needed If the PR does not need E2E smoke test run labels Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f98bdfe
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e4b56074-0204-4082-a416-384a35eac71b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@jpuri jpuri changed the base branch from main to siwe_detection_fix February 5, 2025 04:00
Copy link

sonarqubecloud bot commented Feb 5, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
20.1% Duplication on New Code (required ≤ 10%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants