-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: SIWE signature related changes on personal signature page #13329
Open
jpuri
wants to merge
13
commits into
siwe_detection_fix
Choose a base branch
from
siwe_support
base: siwe_detection_fix
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+369
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
jpuri
added
No E2E Smoke Needed
If the PR does not need E2E smoke test run
Run Smoke E2E
Triggers smoke e2e on Bitrise
and removed
No E2E Smoke Needed
If the PR does not need E2E smoke test run
labels
Feb 4, 2025
Bitrise❌❌❌ Commit hash: f98bdfe Note
Tip
|
OGPoyraz
approved these changes
Feb 4, 2025
app/components/Views/confirmations/components/UI/InfoRow/InfoValue/Network/Network.tsx
Show resolved
Hide resolved
Quality Gate failedFailed conditions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SIWE signature related changes on personal signature page.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4076
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist