Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ramps): updates useQuotes interface to include some quotes metadata #13335

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

georgeweiler
Copy link
Contributor

Description

Following a recent SDK update in v2.0.3 that updated the return structure of some quote endpoints, the useQuotes hook needs to be changed to return more than just the data. This PR updates the interface of the useQuotes hook to return metadata from the getQuotes and getSellQuotes fetch such as sorted instead of returning the data directly.

from this:

{
  data,
  isFetching,
  error,
}

to this:

{
  quotes,
  ...otherMetadata,
  isFetching,
  error,
}

Related issues

Fixes:

Manual testing steps

  1. Go to the ramp experience
  2. confirm that quotes can be loaded

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@georgeweiler georgeweiler added team-ramp issues related to Ramp features needs-ramp-qa Tickets that need feature QA on the ramps flows Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 4, 2025
@georgeweiler georgeweiler requested review from a team as code owners February 4, 2025 13:45
Copy link
Contributor

github-actions bot commented Feb 4, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@consensys/[email protected] 🔁 npm/@consensys/[email protected] None 0 418 kB consensys-npm

View full report↗︎

Copy link
Contributor

github-actions bot commented Feb 4, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 36093b2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/611ffa45-3c99-4892-a2f5-11613144dd96

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ramp-qa Tickets that need feature QA on the ramps flows Run Smoke E2E Triggers smoke e2e on Bitrise team-ramp issues related to Ramp features
Projects
Status: Needs dev review
Development

Successfully merging this pull request may close these issues.

1 participant