Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ramp): sorts ramp quotes by price #13339

Merged
merged 14 commits into from
Feb 7, 2025

Conversation

georgeweiler
Copy link
Contributor

@georgeweiler georgeweiler commented Feb 4, 2025

Description

This PR adds sorting logic to the useQuotes hook to sort quotes by price based on the order provided by the Ramp API.

Related issues

Fixes:

Manual testing steps

  1. Go to ramps experience
  2. confirm that quotes are sorted by price

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@georgeweiler georgeweiler requested review from a team as code owners February 4, 2025 16:26
Copy link
Contributor

github-actions bot commented Feb 4, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-ramp issues related to Ramp features label Feb 4, 2025
@georgeweiler georgeweiler added the Run Smoke E2E Triggers smoke e2e on Bitrise label Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 2555e29
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/56c89002-486b-49d3-a563-3270fba8bb40

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@georgeweiler georgeweiler changed the base branch from main to feat/ramp-use-quotes-interface February 5, 2025 20:50
wachunei
wachunei previously approved these changes Feb 6, 2025
Base automatically changed from feat/ramp-use-quotes-interface to main February 7, 2025 12:53
@georgeweiler georgeweiler dismissed wachunei’s stale review February 7, 2025 12:53

The base branch was changed.

@georgeweiler georgeweiler requested a review from wachunei February 7, 2025 13:22
@georgeweiler georgeweiler added this pull request to the merge queue Feb 7, 2025
Merged via the queue into main with commit 1ea963f Feb 7, 2025
38 of 39 checks passed
@georgeweiler georgeweiler deleted the feat/ramp-sort-quotes-by-price branch February 7, 2025 14:50
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2025
@metamaskbot metamaskbot added the release-7.41.0 Issue or pull request that will be included in release 7.41.0 label Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.41.0 Issue or pull request that will be included in release 7.41.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-ramp issues related to Ramp features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants