GitHub actions, PHPStan, dependencies update

.github/workflows/phpstan.yml

@@ -0,0 +1,39 @@
+name: PHPStan
+
+on: [push, pull_request]
+
+jobs:
+  phpstan:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        php: ['7.1', '7.2', '7.3', '7.4']
+      fail-fast: false
+
+    name: PHP ${{ matrix.php }} PHPStan
+    steps:
+      - uses: actions/checkout@v2
+      - uses: shivammathur/setup-php@v2
+        with:
+          php-version: ${{ matrix.php }}
+
+      - run: composer install --no-progress --prefer-dist
+      - run: vendor/bin/phpstan
+
+  phpstan-lowest:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        php: ['7.1']
+      fail-fast: false
+
+    name: PHP ${{ matrix.php }} PHPStan - lowest dependencies
+    steps:
+      - uses: actions/checkout@v2
+      - uses: shivammathur/setup-php@v2
+        with:
+          php-version: ${{ matrix.php }}
+
+      - run: composer update --no-progress --prefer-dist --prefer-lowest --prefer-stable
+      - run: vendor/bin/phpstan
+

.github/workflows/tests.yml

@@ -0,0 +1,42 @@
+name: Tests
+
+on: [push, pull_request]
+
+env:
+  php-options: -C -d opcache.enable=0 -d zend.exception_ignore_args=0
+
+jobs:
+  tests:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        php: ['7.1', '7.2', '7.3', '7.4']
+      fail-fast: false
+
+    name: PHP ${{ matrix.php }} tests
+    steps:
+      - uses: actions/checkout@v2
+      - uses: shivammathur/setup-php@v2
+        with:
+          php-version: ${{ matrix.php }}
+
+      - run: composer install --no-progress --prefer-dist
+      - run: vendor/bin/tester tests -p php -s ${{ env.php-options }}
+
+  tests-lowest:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        php: ['7.1']
+      fail-fast: false
+
+    name: PHP ${{ matrix.php }} tests - lowest dependencies
+    steps:
+      - uses: actions/checkout@v2
+      - uses: shivammathur/setup-php@v2
+        with:
+          php-version: ${{ matrix.php }}
+
+      - run: composer update --no-progress --prefer-dist --prefer-lowest --prefer-stable
+      - run: vendor/bin/tester tests -p php -s ${{ env.php-options }}
+

composer.json

@@ -20,16 +20,20 @@
     "issues": "https://github.com/MetisFW/PayPal/issues"
   },
   "require": {
-    "php": ">=5.6.0",
+    "php": ">=7.1",
+    "ext-curl": "*",
+    "ext-json": "*",
     "nette/di": "^2.4",
     "nette/application": "^2.4",
-    "paypal/rest-api-sdk-php": "^1.5"
+    "paypal/rest-api-sdk-php": "^1.14"
   },
   "require-dev": {
     "nette/bootstrap": "^2.4",
     "nette/robot-loader": "^2.4",
-    "nette/tester": "^2.4",
-    "mockery/mockery": "^1.4"
+    "nette/tester": "^2.0",
+    "mockery/mockery": "^1.3",
+    "phpstan/phpstan": "^0.11||1.*",
+    "phpstan/phpstan-nette": "*"
   },
   "autoload": {
     "psr-0": {

phpstan.neon

@@ -0,0 +1,9 @@
+parameters:
+	level: 5
+	paths:
+		- src
+		- tests/PayPal
+
+includes:
+	- vendor/phpstan/phpstan-nette/extension.neon
+	- vendor/phpstan/phpstan-nette/rules.neon

src/MetisFW/PayPal/PayPalContext.php

@@ -22,8 +22,7 @@ class PayPalContext {
   private $experienceProfileId;
 
   /**
-   * @param string $clientId
-   * @param string $secret
+   * @param ApiContext $apiContext
    */
   public function __construct(ApiContext $apiContext) {
     $this->apiContext = $apiContext;

src/MetisFW/PayPal/Payment/BasePaymentOperation.php

@@ -60,6 +60,7 @@ protected function getPayer() {
    */
   public function getPayment() {
     $payer = $this->getPayer();
+    /** @phpstan-ignore-next-line */
     if(!$payer || !($payer instanceof Payer)) {
       throw new InvalidArgumentException("Method getPayer has to return instance of Payer. Instead ".
         gettype($payer)." given.");
@@ -106,7 +107,7 @@ public function createPayment(Payment $payment) {
    * @param string $paymentId
    * @param string $payerId
    *
-   * @return void
+   * @return Payment
    */
   public function handleReturn($paymentId, $payerId) {
     try {

src/MetisFW/PayPal/Payment/PaymentOperation.php

@@ -26,7 +26,7 @@ public function createPayment(Payment $payment);
    * @param string $paymentId
    * @param string $payerId
    *
-   * @return void
+   * @return Payment
    */
   public function handleReturn($paymentId, $payerId);
 

src/MetisFW/PayPal/Payment/SimplePaymentOperation.php

@@ -47,7 +47,7 @@ protected function getTransactions() {
     $payPalItem = new Item();
     $payPalItem->setName($this->name);
     $payPalItem->setCurrency($currency);
-    $payPalItem->setQuantity($this->quantity);
+    $payPalItem->setQuantity((string)$this->quantity);
     $payPalItem->setPrice($this->price);
 
     $payPalItems[] = $payPalItem;

tests/PayPal/Helper/TransactionHelper.php

@@ -71,7 +71,7 @@ static public function createItemList(array $items) {
 
   /**
    * @param string $name
-   * @param int $currency
+   * @param string $currency
    * @param int $quantity
    * @param string $sku
    * @param int $price
@@ -81,7 +81,7 @@ static public function createItem($name, $currency, $quantity, $sku, $price) {
     $item = new Item();
     $item->setName($name);
     $item->setCurrency($currency);
-    $item->setQuantity($quantity);
+    $item->setQuantity((string)$quantity);
     $item->setSku($sku);
     $item->setPrice($price);
     return $item;

tests/paypal.config.neon

@@ -4,10 +4,9 @@ payPal:
   currency: EUR
   sdkConfig:
     mode: sandbox
-    log.Enabled: true
+    log.LogEnabled: true
     log.FileName: './tmp/PayPal.log'
-    log.LogLevel: DEBUG
-    validation.level: log
+    log.LogLevel: debug
     cache.enabled: true
     # 'http.CURLOPT_CONNECTTIMEOUT' => 30
     # 'http.headers.PayPal-Partner-Attribution-Id' => '123123123'/

tests/run-tests.sh

@@ -9,4 +9,4 @@ else
   runTests=$dir
 fi
 
-$dir/../vendor/bin/tester -p php -c $dir/php.ini-unix $runTests $@
+$dir/../vendor/bin/tester -p php -C $runTests $@