Add support for OpenFIRE lightguns #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guns are detected as light guns based on static VID and OpenFIRE name prefix, as the PID can be any number of different values depending on the user. Because OpenFIRE guns can be polled through serial devices, a basic (read: hacky) heuristic is used to poll for serial port paths and send a signal to compatible guns to enable their MiSTer compatible mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenFIRE guns do provide a gamepad output mode as an option, but this needs to be signaled from the connected device to use the gamepad output slot (the mouse and keyboard slots effectively go unused for this platform). A small method has been added that searches for the device path of OpenFIRE lightguns and sends the needed command over serial to signal to the gun to automatically use gamepad output without any further user intervention (so no need to pre-configure from a PC).
Has been tested by me and a number of other OF users on both MiSTer Pi and DE10 systems, and shouldn't conflict with other devices as it checks for both a fixed Vendor ID and "OpenFIRE " in the product string, which is prefixed to every shipping gun's USB product name regardless of the user's custom device name appended.