feat(modules/home-manager): add support for configuring environment variables #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Sep 6, 2024
modules/home-manager/sops.nix
Outdated
| Environment variables to set before calling sops-install-secrets. | ||
|
|
||
| The values are placed in single quotes and not escaped any further to | ||
| allow usage of command substitutions for more flexibility. To properly quote |
There was a problem hiding this comment.
Is this actually true? I don't think systemd will do command substitution.
There was a problem hiding this comment.
I don't now about launchd, but it also looks to me that it should be the same.
There was a problem hiding this comment.
That may not be true. I copied the description for the environment option from the NixOS module at modules/sops/default.nix.
I also have only tested the launchd code path. It does work on macOS. I do not have access to a NixOS linux system. Hopefully someone can test the systemd code path.
Added support for configuring environment variables before calling `sops-install-secrets`. Introduced a new `environment` option which allows specifying environment variables. Modified systemd service and launchd agent to use the specified environment variables.
marksisson
force-pushed
the
patches/add-environment-option-to-home-manager-module
branch
from
31b34ca
to
c8c892a
Compare
|
@SebTM could you test linux? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for configuring environment variables before calling
sops-install-secrets. Introduce a newenvironmentoption which allows specifying environment variables. Modify systemd service and launchd agent to use the specified environment variables.