Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dataset-genomics-data-lake.md #29

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

mamtagiri
Copy link

added new dataset info that exists but is not listed here

Copy link
Contributor

@mamtagiri : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link

Learn Build status updates of commit 3b03689:

✅ Validation status: passed

File Status Preview URL Details
articles/open-datasets/dataset-genomics-data-lake.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Jak-MS
Copy link
Contributor

Jak-MS commented Sep 25, 2024

@shubhirajMsft
Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged C+L Pull Request Review Team label label Sep 25, 2024
added important update notice
Copy link
Contributor

Microsoft authors of articles need to make updates through the private repository, so the updates can be staged and validated by current validation rules. After you review staging and fix all validation issues, you can add the sign-off comment to let the PR reviewers know the updates are ready to be merged.

It's easy to access the private repo version of your articles in GitHub. Just add -pr to the URL, as follows:

 Public repo URL: https://github.com/MicrosoftDocs/{docs-repo}
 Private repo URL: https://github.com/MicrosoftDocs/{docs-repo-pr}

We have closed this pull request. Please resubmit the updates through the private repo. For more information, see the contributor guide.

Copy link

Learn Build status updates of commit 6939e9f:

✅ Validation status: passed

File Status Preview URL Details
articles/open-datasets/dataset-genomics-data-lake.md ✅Succeeded
articles/open-datasets/dataset-panancestry-uk-bio-bank.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 0c221d9:

✅ Validation status: passed

File Status Preview URL Details
articles/open-datasets/dataset-genomics-data-lake.md ✅Succeeded
articles/open-datasets/dataset-immunecode.md ✅Succeeded
articles/open-datasets/dataset-panancestry-uk-bio-bank.md ✅Succeeded
articles/open-datasets/dataset-the-cancer-genome-atlas.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

Copy link
Contributor

PRMerger Results

Issue Description
Changed Files This PR contains more than 10 changed files.

@Jak-MS
Copy link
Contributor

Jak-MS commented Sep 25, 2024

@mamtagiri - i've reopened this. the system thinks you, as a Microsoft FTE, should be working in the private repos... it's probably correct. You should work with someone on a content team.

in any case, you aren't allowed to use HTML like '<em></em>' so you'll need to remove that code. Also, if you are adding the same content across a large number of articles, you should consider adding an include file, instead of copy/paste. I'll defer to @shubhirajMsft to advise you on how to proceed. thanks

@mamtagiri
Copy link
Author

@mamtagiri - i've reopened this. the system thinks you, as a Microsoft FTE, should be working in the private repos... it's probably correct. You should work with someone on a content team.

in any case, you aren't allowed to use HTML like '<em></em>' so you'll need to remove that code. Also, if you are adding the same content across a large number of articles, you should consider adding an include file, instead of copy/paste. I'll defer to @shubhirajMsft to advise you on how to proceed. thanks

thank you. I can create an include file instead. Let me know how I can work on this together.

@mamtagiri
Copy link
Author

@mamtagiri - i've reopened this. the system thinks you, as a Microsoft FTE, should be working in the private repos... it's probably correct. You should work with someone on a content team.
in any case, you aren't allowed to use HTML like '<em></em>' so you'll need to remove that code. Also, if you are adding the same content across a large number of articles, you should consider adding an include file, instead of copy/paste. I'll defer to @shubhirajMsft to advise you on how to proceed. thanks

thank you. I can create an include file instead. Let me know how I can work on this together.

@Jak-MS @shubhirajMsft hi please let me know how to proceed. I don't think I have access to the private repo.

@mamtagiri
Copy link
Author

Checking again on merging request. Please let me know what needs to be done to unblock this. This is urgent as we have changes coming to the datasets that we need to put it on the dataset page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants