Updating how we file datapatterns work #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calccrypto
reviewed
Mar 19, 2024
calccrypto
reviewed
Mar 19, 2024
calccrypto
reviewed
Mar 19, 2024
calccrypto
reviewed
Mar 19, 2024
calccrypto
reviewed
Mar 19, 2024
calccrypto
reviewed
Mar 19, 2024
calccrypto
reviewed
Mar 19, 2024
calccrypto
reviewed
Mar 19, 2024
calccrypto
reviewed
Mar 20, 2024
calccrypto
reviewed
Mar 20, 2024
calccrypto
reviewed
Mar 20, 2024
calccrypto
reviewed
Mar 20, 2024
calccrypto
reviewed
Mar 20, 2024
calccrypto
reviewed
Mar 20, 2024
calccrypto
reviewed
Mar 20, 2024
calccrypto
approved these changes
Mar 20, 2024
Previously when the option -datapattern file/wholefile was used, XDD would open the file for every target and keep it open till the run was over. This is really unnecessary as the file only needs to be opened to read the datapattern in to set the datapattern in the target. Once that has happen, the file can immediately be closed. This is a good idea as there are limits to how many files can be opened in Linux (ulimit). XDD should not tie up the number of avialable open file descriptors just to set a datapattern over an entire XDD run. The code has been updated to open the file, set the target data_pattern buffer, and then immediately close the file. I have added a new functional test case test_xdd_file_datapattern.sh to test out that these this modification did not break the expected functionality of -datapattern file/wholefile. There was also just some general cleanup of the code that was done as part of this PR. Signed-off-by: Brian Atkinson <[email protected]>
|
@MigeljanImeri I went ahead and squashed everything into one commit. |
MigeljanImeri
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when the option -datapattern file/wholefile was used, XDD would open the file for every target and keep it open till the run was over. This is really unnecessary as the file only needs to be opened to read the datapattern in to set the datapattern in the target. Once that has happen, the file can immediately be closed. This is a good idea as there are limits to how many files can be opened in Linux (ulimit). XDD should not tie up the number of avialable open file descriptors just to set a datapattern over an entire XDD run.
The code has been updated to open the file, set the target data_pattern buffer, and then immediately close the file. I have added a new functional test case test_xdd_file_datapattern.sh to test out that these this modification did not break the expected functionality of -datapattern file/wholefile.