Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for .NET 8 #8

Closed
Miista opened this issue Jan 13, 2024 · 2 comments · Fixed by #5
Closed

Add support for .NET 8 #8

Miista opened this issue Jan 13, 2024 · 2 comments · Fixed by #5
Assignees
@Miista
Labels
enhancement New feature or request
Milestone
v2.0

Comments

@Miista
Copy link
Owner

Miista commented Jan 13, 2024

The sample app (Sandbox) worked when targeting .NET 7.0 (DateTime.Now returning a timestamp in the year 2004). I have not conducted extensive testing, though.

The same app failed to run when targeting .NET 8.0 due to the Bake... array method.

Originally posted by @stanimirsellercloud in #5 (comment)
@Miista Miista mentioned this issue Jan 13, 2024
Merged
@Miista
Copy link
Owner Author

Miista commented Jan 13, 2024

It looks like the BakeByteArray is missing from ILGenerator on .NET 8. I will need to find out where it has been moved to.

@Miista
Copy link
Owner Author

Miista commented Jan 13, 2024

@stanimirsellercloud I've located the method. It has been moved to RuntimeILGenerator. I have added a preprocessor directive specifically for .NET 8 or greater which locates the method from here instead.

Please note that we still suffer from the same issue as described in #6.

@Miista Miista self-assigned this Jan 13, 2024
@Miista Miista added bug Something isn't working enhancement New feature or request labels Jan 13, 2024
@Miista Miista linked a pull request Jan 13, 2024 that will close this issue
2 fix code #5
Merged
Miista pushed a commit that referenced this issue Jan 13, 2024
@sguldmund
#8 Add support for .NET 8 + .NET 6
ebcb56f 
Closes #8
Closes #6
@Miista Miista removed the enhancement New feature or request label Jan 13, 2024
@Miista Miista mentioned this issue Jan 14, 2024
Open
4 tasks
@Miista Miista added enhancement New feature or request and removed bug Something isn't working labels Jan 14, 2024
@Miista Miista added this to the v2.0 milestone Jan 17, 2024
@Miista Miista closed this as completed in 55a8d06 Jan 17, 2024
@Miista Miista closed this as completed in #5 Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Miista Miista

Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

2 fix code Miista/pose
1 participant
@Miista