Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2 fix code #5

Merged
merged 58 commits into from
Jan 17, 2024
Merged

2 fix code #5

merged 58 commits into from
Jan 17, 2024

Conversation

Miista
Copy link
Owner

@Miista Miista commented Jan 12, 2024 •
edited
Loading

Closes #2
Closes #3

@Miista Miista self-assigned this Jan 12, 2024
@Miista Miista linked an issue Jan 12, 2024 that may be closed by this pull request
Fix code #2
Closed
@sguldmund
#4 Hopefully root out the last remnants of Microsoft-related test fra…
3407527 
…meworks

The following line makes it so that tests are run sequentially.
This seems to be necessary.
If I don't have it, tests seem to fail randomly.

I suspect it's related to the IL being rewritten.
Should probably look further into it.
This was referenced Jan 12, 2024
Open
Open
@stoyanov-x
Copy link

It's great to see this work on .NET 7.0.

However, it looks like the Bake... method is missing or otherwise cannot be used in a .NET 8.0 scenario.

Do you have a plan to support this?

@Miista
Copy link
Owner Author

Miista commented Jan 13, 2024 •
edited
Loading

@stanimirsellercloud Are you thinking of the BakeArray method?

I will definitely look into what alternatives there are.

Maybe that's why the tests are failing on net6+. I'm tracking that in #6.

@Miista
Copy link
Owner Author

Miista commented Jan 13, 2024 •
edited
Loading

@stanimirsellercloud You said it was "great to see [it] work on .NET 7.0". Did you test it on .NET 7.0?

@stoyanov-x
Copy link

The sample app (Sandbox) worked when targeting .NET 7.0 (DateTime.Now returning a timestamp in the year 2004). I have not conducted extensive testing, though.

The same app failed to run when targeting .NET 8.0 due to the Bake... array method.

@Miista
Copy link
Owner Author

Miista commented Jan 13, 2024 •
edited
Loading

I will look into it. Thank you for bringing it up. I'm tracking it in #8.

@Miista Miista mentioned this pull request Jan 13, 2024
Closed
@sguldmund
#8 Locate BakeByteArray method
55a8d06 
In .NET 8 the method has been moved to RuntimeILGenerator which is an internal class.
Thus the unsafe lookup of the type.

Please note that we still suffer from the same issue as described in #6.

Closes #8
@Miista
Copy link
Owner Author

Miista commented Jan 13, 2024

@stanimirsellercloud I've fixed the issue. Please see my comment on #8

@Miista Miista linked an issue Jan 13, 2024 that may be closed by this pull request
Add support for .NET 8 #8
Closed
This was linked to issues Jan 13, 2024
Expand testing #4
Closed
Fix tests for net6.0 #6
Closed
@Miista Miista added this to the v2.0 milestone Jan 17, 2024
@Miista Miista merged commit 36f53c1 into master Jan 17, 2024
1 check passed
@Miista Miista deleted the 2-fix-code branch January 17, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Miista Miista

Labels
None yet
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

Add support for .NET 8 Fix tests for net6.0 Expand testing Add support for netstandard2.0 Fix code
3 participants
@Miista @stoyanov-x @sguldmund