-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create wallet-fee-change #6
base: main
Are you sure you want to change the base?
Conversation
The Proposal is to reduce the wallet creation for from 1 Mina to 0.25 Mina at the next hard fork on condition that a permanent solution is worked on.
very excited to see Minas first MIP! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@minacryptocom Thanks for submitting the first MIP!
I have some feedback regarding the MIP. Additionally, I noticed in your PR comment that you would like this to be conditional on "a long term fix being worked on" for this, but this MIP neither mentions that nor discusses what a long term solution could be for this problem.
Let me know if you have any questions on any of the feedback I left, and I'll be happy to clarify.
MIP Template | ||
This is the suggested template for new MIPs. | ||
|
||
Note that an EIP number will be assigned by an editor. When opening a pull request to submit your EIP, please use an abbreviated title in the filename, `wallet-fee-change.md`. | ||
|
||
The title should be 44 characters or less. It should not repeat the MIP number in title, irrespective of the category. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove this portion of the template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DONE - But I will wait for the other changes before resubmitting the file.
Thanks for the comments, you are right there is no mention of the long term solution. This is a short term, but positive solution to a big issue. I have added a few sentences in the MIP about the method to find the long term solution.
|
||
## Motivation | ||
|
||
The current 1 mina creaiton fee while still relatively small is a barrier for smaller investors. Should the price of Mina rise this will only become more so. With the prevalance of so many other coins, especially in the ZK space that don't have this fee, it may be that Mina Protocol loses out on early investors loyalty. This has additional consequences for community traction and wider interest and developer engagement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you provide more detail in the motivation section on how we should frame our discussion around what an acceptable fee would be?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 0.25 fee was one suggested by Evan Shapiro here https://forums.minaprotocol.com/t/do-you-think-there-should-be-a-fixed-price-to-set-up-a-mina-wallet/4507 and there are interesting discussions around a long term solution in the thread that warrant further discussion. The reality is any changes that require more complex modifications will take time to agree upon and at this time a relatively straightforward change to the fee was thought be a decisive and positive signal of intention. With investors all over the world with different budgets I think it is easy to forget that a small investor is less likely to choose to invest in Mina if a larger part of their capital is 'burned' when they create a wallet. The 0.25 fee is seen as a more affordable option even if Mina's price was to rise considerably in the next 6 months or so, by which time it is hoped a permanent solution would be agreed upon.
|
||
## Motivation | ||
|
||
The current 1 mina creaiton fee while still relatively small is a barrier for smaller investors. Should the price of Mina rise this will only become more so. With the prevalance of so many other coins, especially in the ZK space that don't have this fee, it may be that Mina Protocol loses out on early investors loyalty. This has additional consequences for community traction and wider interest and developer engagement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/creaiton/creation
|
||
## Specification | ||
|
||
***** HELP NEEDED TO COMPLETE THIS PART ****** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once you have sought out the help you need, please remove this line so that it is clear that the MIP is ready to go.
|
||
## Security Considerations | ||
|
||
Lowering the fee down to 0.25 MINA allows not only for users to create addresses easier, but also for malicious actors. A malicious actor could, if the wallet creation fee was low enough, theoretically pollute the ledger with accounts. However, considering the current Dollar-value of Mina at the time of this post, a malicious actor would still need to raise ~$0.9 in order to create an address - therefore a lot of resources would still be needed in order to execute such an attack. Additionally, the ledger is currently of size 2^20, roughly 1,050,000, so with 0.25 MINA wallet creation fee, polluting the ledger would still be a massive hurdle for potential malicious actors. Therefore, we dont forsee any security concerns with lowering the wallet creation fee. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to see a more robust economic argument here for the security implications of this. I think this argument could also be used to drive what fee we end up picking. At the moment, there doesn't seem to be much specific rational behind picking 0.25 besides the fact that it is 1/4 of the current cost.
Even if an attacker does not fill up the ledger, every account an attacker puts into the ledger further increases the load on the networking layer. There are engineering tasks that we can take on that will mitigate this load increase, but at the time being, ledger size increases can increase the amount of time it takes for nodes to bootstrap to the network. This in turn damages our security if the bootstrap time gets too large.
One way you could frame the security implications is to do the math on how long bootstrapping takes at various ledger sizes, and from that compute a formula that tells use how much an adversary can effect bootstrap time per MINA burned to create accounts. This will give us a clearer model to determine a reasonable new account creation fee, and whether or not we would need to take other networking improvements before changing the fee in order to ensure the network is impervious to ledger filling attacks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will come back to you about this. Evan seemed unconcerned it woud be an issue https://forums.minaprotocol.com/t/do-you-think-there-should-be-a-fixed-price-to-set-up-a-mina-wallet/4507/16?u=pete but I will try and obtain some more data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have to agree with @nholland94 - this seems like the right way to approach it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nholland94 - can you provide any tips for @minacryptocom to get started on the math? Will any tests have to be run?
|
||
## Abstract | ||
|
||
Reduce new wallet creation fee from 1mina to .25mina with a caveat to investigating a permenant solution through MinaResearch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a reasonable idea and a great opportunity to enact a community-driven protocol change.
|
||
## Security Considerations | ||
|
||
Lowering the fee down to 0.25 MINA allows not only for users to create addresses easier, but also for malicious actors. A malicious actor could, if the wallet creation fee was low enough, theoretically pollute the ledger with accounts. However, considering the current Dollar-value of Mina at the time of this post, a malicious actor would still need to raise ~$0.9 in order to create an address - therefore a lot of resources would still be needed in order to execute such an attack. Additionally, the ledger is currently of size 2^20, roughly 1,050,000, so with 0.25 MINA wallet creation fee, polluting the ledger would still be a massive hurdle for potential malicious actors. Therefore, we dont forsee any security concerns with lowering the wallet creation fee. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have to agree with @nholland94 - this seems like the right way to approach it.
|
||
## Security Considerations | ||
|
||
Lowering the fee down to 0.25 MINA allows not only for users to create addresses easier, but also for malicious actors. A malicious actor could, if the wallet creation fee was low enough, theoretically pollute the ledger with accounts. However, considering the current Dollar-value of Mina at the time of this post, a malicious actor would still need to raise ~$0.9 in order to create an address - therefore a lot of resources would still be needed in order to execute such an attack. Additionally, the ledger is currently of size 2^20, roughly 1,050,000, so with 0.25 MINA wallet creation fee, polluting the ledger would still be a massive hurdle for potential malicious actors. Therefore, we dont forsee any security concerns with lowering the wallet creation fee. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nholland94 - can you provide any tips for @minacryptocom to get started on the math? Will any tests have to be run?
Paragraph on proof checking ; fixes MinaProtocol#6
My perspective coming from Cardano: Rather than having an account creation fee, have a minimum account balance. This is what Cardano does (link). |
The Proposal is to reduce the wallet creation for from 1 Mina to 0.25 Mina at the next hard fork on condition that a permanent solution is worked on.