Fix a few bugs in revalidate
#16400
Open
Fix a few bugs in revalidate
#16400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This parameter is not used.
This makes code a bit more readable by decreasing the nestedness.
Dropped sequence was returned in reverse order, then concatenated to a sequence in straight order. This is not causing any immediate issues, but is better for clarity.
1. Rewrite revalidate to enhance readability
2. Fix two similar issues originating from confusion between previous
variable names `t` and `t'` ("Account no longer has permission to
send" and "Current account nonce precedes first nonce in queue")
3. Fix the issue #16397 by ensuring removal from `applicable_by_fee` is
done only for the previous head of queue.
This commit only moves part of revalidate function utside of its body.
| @@ -678,132 +678,128 @@ let revalidate : | |||
| -> [ `Entire_pool | `Subset of Account_id.Set.t ] | |||
| -> (Account_id.t -> Account.t) | |||
| -> t * Transaction_hash.User_command_with_valid_signature.t Sequence.t = | |||
| fun t ~logger scope f -> | |||
| fun t ~logger scope get_account_by_id -> | |||
| let requires_revalidation = | |||
There was a problem hiding this comment.
rename to senders_to_validate or some such?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
revalidateanddrop_until_sufficient_balancetandt'(Account no longer has permission to sendandCurrent account nonce precedes first nonce in queue)applicable_by_feeisdone only for the previous head of queue.
Explain how you tested your changes:
Checklist: