Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Develop] Use headers in Best_tip_prover.verify #16518

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

georgeee
Copy link
Member

Twin of:

Use headers in Best_tip_prover.verify.
Use of block-containing structures there is completely unjustified.

This eases integration with Proof_cache_tag.t, and was separately implemented in bitswap workstream.

A step towards Use Proof_cache_tag.t in Ledger_proof.t #16469.

Explain how you tested your changes:

  • It's a refactoring that doesn't change any behavior
  • It compiles :)

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? None

@georgeee georgeee requested review from a team as code owners January 23, 2025 19:16
@georgeee
Copy link
Member Author

!ci-build-me

@georgeee
Copy link
Member Author

!ci-build-me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant