Native prover access #16519
Draft
Native prover access #16519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lities and structures from Marlin and Arkworks crates to OCaml
…lify code and improve readability
…ad of calling into javascript namespace for better maintainability and readability
…c to improve code readability and maintainability
…ity in native bindings
…tter code readability and maintainability
… to clean up code and improve readability
…from constructor, getter, and setter functions to clean up the code and improve readability
…o clean up the file refactor(oracles.rs): change the return type of the function to Result with a String error message for better error handling
…ode and improve readability
…or)] annotation from WasmGateWires constructor function
definitions for WasmPastaFpPlonkIndex, WasmPastaFpLookupTable, WasmPastaFpRuntimeTableCfg, and related methods for creating, encoding, decoding, reading, and writing Plonk indexes in a WebAssembly environment.
…notations and comments to clean up the code and improve readability
…to clean up code and improve readability
implementations for WasmPastaFqPlonkIndex and WasmPastaFqLookupTable structs, conversion methods, and CamlPastaFqPlonkIndex methods for creating, decoding, encoding, reading, and writing ProverIndex instances. Also, include support for RuntimeTableCfg and ConstraintSystem functionalities.
…notations and adjust struct definitions for better code readability and maintainability
proof structures and conversion functions for wasm bindings
…lean up the code and improve readability
implementation of verification key structs and conversion functions for serialization and deserialization to support Plonk verifier index in Pasta Fp and Pasta Fq curves
…ions to clean up the code and improve readability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome 👋
Thank you for contributing to Mina! Please see
CONTRIBUTING.mdif you haven'tyet. In that doc, there are more details around how to start our CI.
If you cannot complete any of the steps below, please ask for help from a core
contributor.
Incomplete Work
We feel it's important that everyone is comfortable landing incomplete projects
so we don't keep PRs open for too long (especially on develop). To do this we
don't want to forget that something is incomplete, don't want to be blocked on
landing things, and we don't want to land anything that breaks the daemon. We
don't want to forget to test the incomplete things whenever they are completed,
and finally we want to clean up after ourselves: any temporary cruft gets
completely removed before a project is considered done.
To achieve the above, we wish to keep track of incomplete work using a draft of
the release notes. We can share this part of the current draft at anytime with
external contributors. Moreover, we will review this draft during hardforks.
To ship incomplete work, put it behind feature flags -- prefer a runtime
CLI/daemon-config-style flag if possible, and only if necessary fallthrough to
compile time flags. Note that if you put code behind a compile time flag, you
must ensure that CI is building all possible code paths. Don't land something
that doesn't build in CI.
PLEASE DELETE EVERYTHING ABOVE THIS LINE
Explain your changes:
*
Explain how you tested your changes:
*
Checklist: