Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove transaction_witness.mli #16557

Open
wants to merge 1 commit into
base: compatible
Choose a base branch
from

Conversation

georgeee
Copy link
Member

@georgeee georgeee commented Feb 3, 2025

This interface file is an exact copy of the transaction_witness.ml, hence it's redundant to keep it.

Explain how you tested your changes:

  • An extra-simple refactoring, and it compiles

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? None

This interface file is an exact copy of the transaction_witness.ml,
hence it's redundant to keep it.
@georgeee georgeee requested a review from a team as a code owner February 3, 2025 13:31
@georgeee
Copy link
Member Author

georgeee commented Feb 3, 2025

!ci-build-me

@dannywillems
Copy link
Member

dannywillems commented Feb 3, 2025

Don't we want to keep the mli and modify it step by step? It's been added automatically i guess using ocamlc. Always good to have interfaces!

Copy link
Member

@mrmr1993 mrmr1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's generally better to remove the .ml file instead, and mark it as such in dune. Implementation compilation is more expensive than interface compilation, so this is likely to slow down the build process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants