Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small refactroing of transaction_pool.ml #16558

Open
wants to merge 3 commits into
base: compatible
Choose a base branch
from

Conversation

georgeee
Copy link
Member

@georgeee georgeee commented Feb 3, 2025

Prettify code a little bit, move some code around.

This refactoring is useful for a much large effort in #16556.

Explain how you tested your changes:

  • An extra-simple refactoring, and it compiles

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? None

Prettify code: expand an incoming envelope to a bunch of local variables
and use them instead of an envlope.
Remove unnecessary use of local variable.
Extract an inlined function to the scope of module.
@georgeee georgeee requested a review from a team as a code owner February 3, 2025 13:32
@georgeee
Copy link
Member Author

georgeee commented Feb 3, 2025

!ci-build-me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant