Don't compute staged ledger hash on every RPC call #16568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: RPC get_staged_ledger_aux_and_pending_coinbases_at_hash computes staged ledger hash on every call, which is unnecessary expensive. Solution: compute hash once and store it in the breadcrumb, then use on each invocation of RPC.
|
!ci-build-me |
mrmr1993
approved these changes
Feb 4, 2025
For the genesis block staged ledger hash is computed differently than for other blocks, and it needs to be accounted for.
|
!ci-build-me |
svv232
approved these changes
Feb 5, 2025
Comment on lines
13
to
+16
| ; staged_ledger : Staged_ledger.t | ||
| ; just_emitted_a_proof : bool | ||
| ; transition_receipt_time : Time.t option | ||
| ; staged_ledger_hash : Staged_ledger_hash.t |
There was a problem hiding this comment.
nit it feels a little odd that the staged ledger and the hash are decoupled, but i understand why you don't want to stick a new field into the staged ledger.
There was a problem hiding this comment.
Yeah, staged ledger is a mutable structure, we'd need to think carefully about semantics of use
Breadcrumb doesn't enforce immutability of underlying staged ledger in any way, but it's being assumed by convention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: RPC get_staged_ledger_aux_and_pending_coinbases_at_hash computes staged ledger hash on every call, which is unnecessary expensive.
Solution: use staged ledger hash from breadcrumb on each invocation of RPC.
Explain how you tested your changes:
Checklist: