fix

core/minter/minter.go

@@ -133,7 +133,8 @@ func (app *Blockchain) BeginBlock(req abciTypes.RequestBeginBlock) abciTypes.Res
 	}
 
 	// give penalty to Byzantine validators
-	for _, v := range req.ByzantineValidators {
+	for i := range req.ByzantineValidators {
+		v := &req.ByzantineValidators[i]
 		var address [20]byte
 		copy(address[:], v.Validator.Address)
 
@@ -320,8 +321,8 @@ func (app *Blockchain) Commit() abciTypes.ResponseCommit {
 
 	// todo: make provider
 	height := make([]byte, 8)
-	binary.BigEndian.PutUint64(height[:], app.height)
-	err = appTable.Put([]byte("height"), height[:])
+	binary.BigEndian.PutUint64(height, app.height)
+	err = appTable.Put([]byte("height"), height)
 
 	if err != nil {
 		panic(err)

core/state/statedb.go

@@ -230,7 +230,7 @@ func (s *StateDB) updateStateFrozenFund(stateFrozenFund *stateFrozenFund) {
 		panic(fmt.Errorf("can't encode frozen fund at %d: %v", blockHeight, err))
 	}
 	height := make([]byte, 8)
-	binary.BigEndian.PutUint64(height[:], stateFrozenFund.blockHeight)
+	binary.BigEndian.PutUint64(height, stateFrozenFund.blockHeight)
 
 	key := append(frozenFundsPrefix, height...)
 	s.setError(s.trie.TryUpdate(key, data))
@@ -280,7 +280,7 @@ func (s *StateDB) deleteStateCoin(stateCoin *stateCoin) {
 func (s *StateDB) deleteFrozenFunds(stateFrozenFund *stateFrozenFund) {
 	stateFrozenFund.deleted = true
 	height := make([]byte, 8)
-	binary.BigEndian.PutUint64(height[:], stateFrozenFund.blockHeight)
+	binary.BigEndian.PutUint64(height, stateFrozenFund.blockHeight)
 	key := append(frozenFundsPrefix, height...)
 	s.setError(s.trie.TryDelete(key))
 }
@@ -293,7 +293,7 @@ func (s *StateDB) getStateFrozenFunds(blockHeight uint64) (stateFrozenFund *stat
 	}
 
 	height := make([]byte, 8)
-	binary.BigEndian.PutUint64(height[:], blockHeight)
+	binary.BigEndian.PutUint64(height, blockHeight)
 	key := append(frozenFundsPrefix, height...)
 
 	// Load the object from the database.
@@ -640,16 +640,14 @@ func (s *StateDB) Commit(deleteEmptyObjects bool) (root types.Hash, err error) {
 	// Commit coins to the trie.
 	for symbol, stateCoin := range s.stateCoins {
 		_, isDirty := s.stateCoinsDirty[symbol]
-		switch {
-		case isDirty:
-			{
-				if stateCoin.data.Volume.Cmp(types.Big0) == 0 {
-					s.deleteStateCoin(stateCoin)
-				} else {
-					s.updateStateCoin(stateCoin)
-				}
+		if isDirty {
+			if stateCoin.data.Volume.Cmp(types.Big0) == 0 {
+				s.deleteStateCoin(stateCoin)
+			} else {
+				s.updateStateCoin(stateCoin)
 			}
 		}
+
 		delete(s.stateCoinsDirty, symbol)
 	}
 

core/transaction/declare_candidacy.go

@@ -41,7 +41,7 @@ func (data DeclareCandidacyData) MarshalJSON() ([]byte, error) {
 
 func (data DeclareCandidacyData) String() string {
 	return fmt.Sprintf("DECLARE CANDIDACY address:%s pubkey:%s commission: %d ",
-		data.Address.String(), hexutil.Encode(data.PubKey[:]), data.Commission)
+		data.Address.String(), hexutil.Encode(data.PubKey), data.Commission)
 }
 
 func (data DeclareCandidacyData) Gas() int64 {

core/transaction/delegate.go

@@ -32,7 +32,7 @@ func (data DelegateData) MarshalJSON() ([]byte, error) {
 
 func (data DelegateData) String() string {
 	return fmt.Sprintf("DELEGATE pubkey:%s ",
-		hexutil.Encode(data.PubKey[:]))
+		hexutil.Encode(data.PubKey))
 }
 
 func (data DelegateData) Gas() int64 {

core/transaction/unbond.go

@@ -34,7 +34,7 @@ func (data UnbondData) MarshalJSON() ([]byte, error) {
 
 func (data UnbondData) String() string {
 	return fmt.Sprintf("UNBOND pubkey:%s",
-		hexutil.Encode(data.PubKey[:]))
+		hexutil.Encode(data.PubKey))
 }
 
 func (data UnbondData) Gas() int64 {

core/types/bytes.go

@@ -94,7 +94,7 @@ func Hex2BytesFixed(str string, flen int) []byte {
 			return h[len(h)-flen:]
 		} else {
 			hh := make([]byte, flen)
-			copy(hh[flen-len(h):flen], h[:])
+			copy(hh[flen-len(h):flen], h)
 			return hh
 		}
 	}

hexutil/json.go

@@ -173,7 +173,7 @@ func (b *Big) UnmarshalText(input []byte) error {
 	}
 	var dec big.Int
 	dec.SetBits(words)
-	*b = (Big)(dec)
+	*b = Big(dec)
 	return nil
 }