Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: Add Vietnamese translations and configuration #2641

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

bibo318
Copy link

@bibo318 bibo318 commented Nov 18, 2024

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

connect #none


What is in this change?

This Pull Request introduces Vietnamese language support to the project. The following changes have been made:

  1. Added common.js file in the vi directory with full Vietnamese translations.
  2. Updated the resources configuration to include Vietnamese (vi) namespace.
  3. Ensured compatibility with existing language toggle functionality.

Additional Information

  • This update broadens the platform's accessibility for Vietnamese-speaking users, aligning with the project's internationalization goals.
  • No breaking changes introduced, and existing language functionality remains unaffected.

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes.
  • Relevant documentation has been updated.
  • I have tested my code functionality.
  • Docker build succeeds locally.

@timothycarambat
Copy link
Member

Is it intentional that this is a partial completion of the translation file?

@bibo318
Copy link
Author

bibo318 commented Nov 19, 2024

Is it intentional that this is a partial completion of the translation file?

Yes, this is intentional. The translation file currently includes key phrases and components critical for the initial Vietnamese support. We plan to extend the translation to cover additional keys and modules in subsequent updates to ensure full coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants