Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 'on-error - ignore-all' #207

Merged
merged 1 commit into from
Feb 28, 2017

Conversation

gluke77
Copy link
Contributor

@gluke77 gluke77 commented Feb 27, 2017

Partially addresses #80


This change is Reviewable

@gluke77 gluke77 changed the title Implement on-error:ignore-all Implement on-error - ignore-all Feb 27, 2017
@gluke77 gluke77 changed the title Implement on-error - ignore-all Implement 'on-error - ignore-all' Feb 27, 2017
@nebril
Copy link
Contributor

nebril commented Feb 28, 2017

Review status: 0 of 11 files reviewed at latest revision, 1 unresolved discussion.


e2e/basic_test.go, line 181 at r1 (raw file):

		Context("If failed parent is marked on-error:ignore-all", func() {
			It("all children including transitive must not be created", func() {
				parentResDef := framework.WrapWithMetaAndCreate(parentPod, map[string]interface{}{"timeout": 5, "on-error": "ignore"})

Shouldn't ignore be changed to ignore-all? Does this test test what it needs if it works with ignore?


Comments from Reviewable

@gluke77
Copy link
Contributor Author

gluke77 commented Feb 28, 2017

Review status: 0 of 11 files reviewed at latest revision, 1 unresolved discussion.


e2e/basic_test.go, line 181 at r1 (raw file):

Previously, nebril (Maciej Kwiek) wrote…

Shouldn't ignore be changed to ignore-all? Does this test test what it needs if it works with ignore?

sure!! great catch


Comments from Reviewable

@jellonek
Copy link
Contributor

:lgtm:


Reviewed 11 of 11 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@nebril
Copy link
Contributor

nebril commented Feb 28, 2017

Reviewed 11 of 11 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@gluke77
Copy link
Contributor Author

gluke77 commented Feb 28, 2017

Review status: 10 of 11 files reviewed at latest revision, 1 unresolved discussion.


e2e/basic_test.go, line 181 at r1 (raw file):

Previously, gluke77 (Illia Khudoshyn) wrote…

sure!! great catch

updated


Comments from Reviewable

@jellonek
Copy link
Contributor

:lgtm:


Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@nebril
Copy link
Contributor

nebril commented Feb 28, 2017

:lgtm:


Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@nebril
Copy link
Contributor

nebril commented Feb 28, 2017

Reviewed 1 of 1 files at r2.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

@nebril nebril merged commit 3380fc3 into Mirantis:master Feb 28, 2017
@gluke77 gluke77 deleted the failure-handling-ignore-all branch February 28, 2017 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants