Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling non-dict SNS messages #2198

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

piotrdrazikowski
Copy link
Contributor

Description

The main SNS message handler incorrectly assumes that every message that was parsed using json.loads() without throwing an exception is of dict type, and then uses dict methods like .get() on the parsed object which eventually leads to a crash. In our case this has prevented us from sending a list of dicts, but there's more examples. This PR fixes it by handling the AttributeError exception

GitHub Issues

#1466
#1864

@coveralls
Copy link

coveralls commented Jan 11, 2021

Coverage Status

Coverage remained the same at 72.975% when pulling 1e7d9c1 on protagonistllc:bugfix/non-dict-sns-message-handling into 542c8c6 on Miserlou:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants