Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] Refactoring of hyperscript.js and render.js, including performance improvements #2983

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[refactor] Refactoring of hyperscript.js and render.js, including performance improvements #2983

wants to merge 7 commits into from
+29 −44

Commits on Oct 21, 2024

  1. [refactor] hyperscript: use assign() to construct attrs in execSelect… 

    …or()
    @kfule
    kfule committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    4c93c3c View commit details
    Browse the repository at this point in the history

  2. [refactor] hyperscript: don't use isEmpty() in execSelector()

    @kfule
    kfule committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    ba38410 View commit details
    Browse the repository at this point in the history

  3. [refactor] hyperscript: simplify className assignment logic when stat… 

    …e.attrs == null
    @kfule
    kfule committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    75b2f02 View commit details
    Browse the repository at this point in the history

  4. [refactor] hyperscript: use Object.create(null) for selectorCache

    @kfule
    kfule committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    d4f8f50 View commit details
    Browse the repository at this point in the history

  5. [refactor] performance improvement by replacing MithrilJS#2622 fix in… 

    … render.js with another workaround in hyperscript.js

The input[type] inspection at the beginning of setAttr() was called for each attribute. This had a negative impact on performance. The new workaround in execSelector() controls the order of setting attributes by reordering the keys in attrs.
    @kfule
    kfule committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    69c0017 View commit details
    Browse the repository at this point in the history

  6. [refactor] render: move isFileInput into setAttr() 

    The isFileInput is needed only when key is "value", so moving the logic into setAttr() would not increase time of calculation. Also, the code outlook improves a bit, of course.
    @kfule
    kfule committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    b673ed7 View commit details
    Browse the repository at this point in the history

  7. remove polyfill for Object.assign() 

    The polyfill doesn't support multiple source objects, and almost all browsers now natively support Object.assign().
    @kfule
    kfule committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    d10e01d View commit details
    Browse the repository at this point in the history